You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by jl...@apache.org on 2022/11/07 22:57:46 UTC
[pinot] branch test-async-query-execution updated (a864122120 -> 67ea5d919c)
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch test-async-query-execution
in repository https://gitbox.apache.org/repos/asf/pinot.git
omit a864122120 Add sample code to show how pagination protocol works in broker code
new 67ea5d919c Add sample code to show how pagination protocol works in broker code
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (a864122120)
\
N -- N -- N refs/heads/test-async-query-execution (67ea5d919c)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../requesthandler/BaseBrokerRequestHandler.java | 118 +++++++++++----------
1 file changed, 60 insertions(+), 58 deletions(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[pinot] 01/01: Add sample code to show how pagination protocol works in broker code
Posted by jl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch test-async-query-execution
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 67ea5d919c3d3aa5759eac16a776cd7efaab83db
Author: Jack Li(Analytics Engineering) <jl...@jlli-mn1.linkedin.biz>
AuthorDate: Fri Nov 4 16:39:28 2022 -0700
Add sample code to show how pagination protocol works in broker code
---
.../requesthandler/BaseBrokerRequestHandler.java | 79 +++++++++++++++++++---
.../tests/BaseClusterIntegrationTest.java | 2 +-
2 files changed, 70 insertions(+), 11 deletions(-)
diff --git a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
index 224f46c440..6e49fd64c8 100644
--- a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
+++ b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
@@ -21,6 +21,7 @@ package org.apache.pinot.broker.requesthandler;
import com.fasterxml.jackson.databind.JsonNode;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Preconditions;
+import java.io.IOException;
import java.net.InetAddress;
import java.util.ArrayList;
import java.util.Arrays;
@@ -30,6 +31,8 @@ import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.CompletionException;
import java.util.concurrent.CompletionService;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.Executor;
@@ -273,6 +276,7 @@ public abstract class BaseBrokerRequestHandler implements BrokerRequestHandler {
PinotQuery pinotQuery;
try {
// Parse the request
+ // TODO: consider adding the option from subquery if sqlNodeAndOptions isn't null?
sqlNodeAndOptions = sqlNodeAndOptions != null ? sqlNodeAndOptions : RequestUtils.parseQuery(query, request);
// Compile the request into PinotQuery
compilationStartTimeNs = System.nanoTime();
@@ -371,6 +375,63 @@ public abstract class BaseBrokerRequestHandler implements BrokerRequestHandler {
_brokerMetrics.addPhaseTiming(rawTableName, BrokerQueryPhase.AUTHORIZATION,
System.nanoTime() - compilationEndTimeNs);
+ if (Boolean.parseBoolean(pinotQuery.getQueryOptions().get("pagination"))) {
+// String tableName = TableNameBuilder.extractRawTableName(pinotQuery.getDataSource().getTableName());
+ // Step 1: Generate a pointer.
+ // TODO: a. add a method to generate a ID
+ // b. replace the dummyInstanceId with a real one.
+ int hash = ("dummyInstanceId" + requestId + System.currentTimeMillis()).hashCode();
+ String pointer = tableName + "_" + hash;
+
+ // Step 2: TODO invoke pagination query initialization API.
+
+ // Step 3: Submit to query executor.
+ // TODO: use an pool based executor as the 2nd parameter below.
+ CompletableFuture.supplyAsync(() -> {
+ try {
+ return handleRequest(requestId, query, serverPinotQuery, brokerRequest, serverBrokerRequest,
+ compilationStartTimeNs, tableName, rawTableName, requesterIdentity, requestContext);
+ } catch (Exception e) {
+ throw new CompletionException(e);
+ }
+ }).thenApply(brokerResponseNative -> {
+ // Step 5: TODO invoke upload result API.
+ try {
+ System.out.println("Async query execution response: " + brokerResponseNative.toJsonString());
+ return null;
+ } catch (IOException e) {
+ throw new CompletionException(e);
+ }
+ }).exceptionally(exception -> {
+ // Step 6: TODO Handle exception.
+ System.out.println(exception);
+ return null;
+ });
+
+ // Step 4: TODO Put pointer only to the response and return.
+ BrokerResponseNative brokerResponseNative = new BrokerResponseNative();
+
+ DataSchema dataSchema =
+ new DataSchema(new String[]{"pointer"}, new DataSchema.ColumnDataType[]{DataSchema.ColumnDataType.STRING});
+ Object[] objects = new Object[]{pointer};
+ List<Object[]> rows = new ArrayList<>();
+ rows.add(objects);
+ ResultTable resultTable = new ResultTable(dataSchema, rows);
+ brokerResponseNative.setResultTable(resultTable);
+ System.out.println("Submission response: " + brokerResponseNative.toJsonString());
+ return brokerResponseNative;
+ }
+
+ return handleRequest(requestId, query, serverPinotQuery, brokerRequest, serverBrokerRequest, compilationStartTimeNs,
+ tableName, rawTableName, requesterIdentity, requestContext);
+ }
+
+ // Exclude query compilation + authorization.
+ private BrokerResponseNative handleRequest(long requestId, String query, PinotQuery serverPinotQuery,
+ BrokerRequest brokerRequest, BrokerRequest serverBrokerRequest, long compilationStartTimeNs, String tableName,
+ String rawTableName, @Nullable RequesterIdentity requesterIdentity, RequestContext requestContext)
+ throws Exception {
+
// Get the tables hit by the request
String offlineTableName = null;
String realtimeTableName = null;
@@ -520,7 +581,7 @@ public abstract class BaseBrokerRequestHandler implements BrokerRequestHandler {
}
if (offlineBrokerRequest == null && realtimeBrokerRequest == null) {
- if (pinotQuery.isExplain()) {
+ if (serverPinotQuery.isExplain()) {
// EXPLAIN PLAN results to show that query is evaluated exclusively by Broker.
return BrokerResponseNative.BROKER_ONLY_EXPLAIN_PLAN_OUTPUT;
}
@@ -528,8 +589,7 @@ public abstract class BaseBrokerRequestHandler implements BrokerRequestHandler {
// Send empty response since we don't need to evaluate either offline or realtime request.
BrokerResponseNative brokerResponse = BrokerResponseNative.empty();
// Extract source info from incoming request
- _queryLogger.log(new QueryLogger.QueryLogParams(
- requestId, query, requestContext, tableName, 0, new ServerStats(),
+ _queryLogger.log(new QueryLogger.QueryLogParams(requestId, query, requestContext, tableName, 0, new ServerStats(),
brokerResponse, System.nanoTime(), requesterIdentity));
return brokerResponse;
}
@@ -640,7 +700,7 @@ public abstract class BaseBrokerRequestHandler implements BrokerRequestHandler {
// - Compile time function invocation
// - Literal only queries
// - Any rewrites
- if (pinotQuery.isExplain()) {
+ if (serverPinotQuery.isExplain()) {
// Update routing tables to only send request to offline servers for OFFLINE and HYBRID tables.
// TODO: Assess if the Explain Plan Query should also be routed to REALTIME servers for HYBRID tables
if (offlineRoutingTable != null) {
@@ -670,9 +730,9 @@ public abstract class BaseBrokerRequestHandler implements BrokerRequestHandler {
LOGGER.debug("Remove track of running query: {}", requestId);
}
} else {
- brokerResponse = processBrokerRequest(requestId, brokerRequest, serverBrokerRequest, offlineBrokerRequest,
- offlineRoutingTable, realtimeBrokerRequest, realtimeRoutingTable, remainingTimeMs, serverStats,
- requestContext);
+ brokerResponse =
+ processBrokerRequest(requestId, brokerRequest, serverBrokerRequest, offlineBrokerRequest, offlineRoutingTable,
+ realtimeBrokerRequest, realtimeRoutingTable, remainingTimeMs, serverStats, requestContext);
}
brokerResponse.setExceptions(exceptions);
@@ -696,9 +756,8 @@ public abstract class BaseBrokerRequestHandler implements BrokerRequestHandler {
// Extract source info from incoming request
_queryLogger.log(
- new QueryLogger.QueryLogParams(
- requestId, query, requestContext, tableName, numUnavailableSegments, serverStats, brokerResponse,
- totalTimeMs, requesterIdentity));
+ new QueryLogger.QueryLogParams(requestId, query, requestContext, tableName, numUnavailableSegments, serverStats,
+ brokerResponse, totalTimeMs, requesterIdentity));
return brokerResponse;
}
diff --git a/pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java b/pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java
index b133a27551..73f80d78cb 100644
--- a/pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java
+++ b/pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java
@@ -592,7 +592,7 @@ public abstract class BaseClusterIntegrationTest extends ClusterTest {
}
protected long getCurrentCountStarResult(String tableName) {
- return getPinotConnection().execute("SELECT COUNT(*) FROM " + tableName).getResultSet(0).getLong(0);
+ return getPinotConnection().execute("SET pagination = true; SELECT COUNT(*) FROM " + tableName).getResultSet(0).getLong(0);
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org