You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "hewenting (Code Review)" <ge...@cloudera.org> on 2016/09/06 01:29:35 UTC

[Impala-ASF-CR] IMPALA-4075: Fix import kudu module exception on conftest.py 

hewenting has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4312

Change subject: IMPALA-4075: Fix import kudu module exception on conftest.py
......................................................................

IMPALA-4075: Fix import kudu module exception on conftest.py

  Judge environment variable "KUDU_IS_SUPPORTED" first,
  only this variable is set to true, we can import kudu module.

Change-Id: Idd22f1ca10651c86841bc1ed7d108b26e3d16ee9
---
M tests/conftest.py
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/4312/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd22f1ca10651c86841bc1ed7d108b26e3d16ee9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: hewenting <he...@163.com>

[Impala-ASF-CR] IMPALA-4075: Fix import kudu module exception on conftest.py

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.

Change subject: IMPALA-4075: Fix import kudu module exception on conftest.py
......................................................................


Patch Set 1:

Hello hewenting, any updates?

Regarding this comment of mine:

> Fix underlying cause of IMPALA-4075, in which Impala and Kudu aren't working well together in your dev environment. This should be working, and it isn't. Why not?

I should add that I forgot until now some Linux distributions aren't supported with Kudu, so that is certainly a valid use case (among others) for explicit KUDU_IS_SUPPORTED=false. But it would be good to confirm this valid for you.

I'm certainly open to a solution along the lines of #2 above.

-- 
To view, visit http://gerrit.cloudera.org:8080/4312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd22f1ca10651c86841bc1ed7d108b26e3d16ee9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: hewenting <he...@163.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4075: Fix import kudu module exception on conftest.py

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has abandoned this change.

Change subject: IMPALA-4075: Fix import kudu module exception on conftest.py
......................................................................


Abandoned

have been waiting on hewenting for 8 months without a response

-- 
To view, visit http://gerrit.cloudera.org:8080/4312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Idd22f1ca10651c86841bc1ed7d108b26e3d16ee9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: hewenting <he...@163.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-4075: Fix import kudu module exception on conftest.py

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.

Change subject: IMPALA-4075: Fix import kudu module exception on conftest.py
......................................................................


Patch Set 1:

Thanks for the patch. My personal preference would be to have a more comprehensive patch that does one of these, in order of preference:

1. Fix underlying cause of IMPALA-4075, in which Impala and Kudu aren't working well together in your dev environment. This should be working, and it isn't. Why not?

2. A more comprehensive strategy to support "KUDU_IS_SUPPORTED=false" scenarios. It's not tenable to inspect the environment variable all over the place. A solution here would be to augment tests/common/environ.py to be a method or variable that reports whether kudu is supported, and fix up the handful of places that inspect the KUDU_IS_SUPPORTED environment variable directly.

-- 
To view, visit http://gerrit.cloudera.org:8080/4312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd22f1ca10651c86841bc1ed7d108b26e3d16ee9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: hewenting <he...@163.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No