[GitHub] brodybits commented on a change in pull request #56: Test framework consistency

[GitBox <gi...@apache.org>]

brodybits commented on a change in pull request #56: Test framework consistency
URL: https://github.com/apache/cordova-osx/pull/56#discussion_r216988067
 
 

 ##########
 File path: package.json
 ##########
 @@ -41,7 +41,7 @@
     "eslint-plugin-node": "^5.0.0",
     "eslint-plugin-promise": "^3.5.0",
     "eslint-plugin-standard": "^3.0.1",
-    "jasmine": "^2.6.0",
+    "jasmine": "^3.1.0",
 
 Review comment:
   `"jasmine": "^3.1.0"` really means `"jasmine": "^3.2.0"`, which you can see in the changes to `package-lock.json`; I recall jasmine@3.2.0 not working on some other packages.
   
   If you really meant jasmine@3.1.x then please use tilde (`~`) as in:
   
       "jasmine": "~3.1.0",
   
   If you are sure that jasmine@3.2.0 will work then please update as `"jasmine": "^3.2.0"` to avoid any possible confusion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org