You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/27 03:53:53 UTC
[GitHub] [iotdb] jun0315 opened a new pull request #5351: [IOTDB-2806][InfluxDB] Compatibility of Apache IoTDB with InfluxDB - Complete UserGuide
jun0315 opened a new pull request #5351:
URL: https://github.com/apache/iotdb/pull/5351
See more details:https://issues.apache.org/jira/browse/IOTDB-2806.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jun0315 commented on a change in pull request #5351: [IOTDB-2806][InfluxDB] Compatibility of Apache IoTDB with InfluxDB - Complete UserGuide
Posted by GitBox <gi...@apache.org>.
jun0315 commented on a change in pull request #5351:
URL: https://github.com/apache/iotdb/pull/5351#discussion_r835914724
##########
File path: docs/zh/UserGuide/API/InfluxDB-Protocol.md
##########
@@ -24,26 +24,26 @@
假如您原先接入 InfluxDB 的业务代码如下：
```java
-InfluxDB influxDB = InfluxDBFactory.connect(openurl, username, password);
+InfluxDB influxDB=InfluxDBFactory.connect(openurl,username,password);
```
您只需要将 InfluxDBFactory 替换为 **IoTDBInfluxDBFactory** 即可实现业务向 IoTDB 的切换：
```java
-InfluxDB influxDB = IoTDBInfluxDBFactory.connect(openurl, username, password);
+InfluxDB influxDB=IoTDBInfluxDBFactory.connect(openurl,username,password);
```
Review comment:
Thanks for your review, in this file, I use the formatting shortcut provided by IDEA. Maybe it automatically formats the Java code block of makedown into this style. I think this may not be elegant. I have reverted to the previous version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jun0315 commented on pull request #5351: [IOTDB-2806][InfluxDB] Compatibility of Apache IoTDB with InfluxDB - Complete UserGuide
Posted by GitBox <gi...@apache.org>.
jun0315 commented on pull request #5351:
URL: https://github.com/apache/iotdb/pull/5351#issuecomment-1081763971
@tsunghanjacktsai
I am writing an English version :D
The English version of the user guide will be submitted in this pr~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] tsunghanjacktsai commented on a change in pull request #5351: [IOTDB-2806][InfluxDB] Compatibility of Apache IoTDB with InfluxDB - Complete UserGuide
Posted by GitBox <gi...@apache.org>.
tsunghanjacktsai commented on a change in pull request #5351:
URL: https://github.com/apache/iotdb/pull/5351#discussion_r835896517
##########
File path: docs/zh/UserGuide/API/InfluxDB-Protocol.md
##########
@@ -24,26 +24,26 @@
假如您原先接入 InfluxDB 的业务代码如下：
```java
-InfluxDB influxDB = InfluxDBFactory.connect(openurl, username, password);
+InfluxDB influxDB=InfluxDBFactory.connect(openurl,username,password);
```
您只需要将 InfluxDBFactory 替换为 **IoTDBInfluxDBFactory** 即可实现业务向 IoTDB 的切换：
```java
-InfluxDB influxDB = IoTDBInfluxDBFactory.connect(openurl, username, password);
+InfluxDB influxDB=IoTDBInfluxDBFactory.connect(openurl,username,password);
```
Review comment:
LGTM overall. But is there any reason for removing the blank spaces here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org