You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Benedikt Ritter <be...@systemoutprintln.de> on 2012/02/13 23:50:11 UTC

Re: [jira] [Resolved] (SANDBOX-389) [BeanUtils2] Implement populate() on DefaultBeanAccessor

Hi Simo,

thanks for applying my patches!

Sorry about the license header position. You told me that twice. Stupid 
eclipse does not understand that it has to put the imports under the 
license. I'll pay more attention to that.

And sorry about the tabs in pom.xml. I've configured eclipse to use 
spaces only. Sadly that does just affect the Java editor. Do you know a 
way to configure the pom source editor to use spaces instead of tabs?

About commons-lang version: your right, having a version property does 
only make sense when you're using several components of one vendor (like 
spring framework)

Have a nice start into the new week!
Benedikt

Am 13.02.2012 23:35, schrieb Simone Tripodi (Resolved) (JIRA):
>
>       [ https://issues.apache.org/jira/browse/SANDBOX-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Simone Tripodi resolved SANDBOX-389.
> ------------------------------------
>
>      Resolution: Fixed
>        Assignee: Simone Tripodi
>
> Patch applied, see [r1243720|http://svn.apache.org/viewvc?rev=1243720&view=rev] but please:
>
>   * pay attention on new files where license header is located, its proper location is {{before}} the import statements
>
>   * inverted logic in {{continue}} statements;
>
>   * *NO TABS* in pom XML;
>
>   * why did you think putting the {{commons-lang}} version as property would be a benefit?
>
>> [BeanUtils2] Implement populate() on DefaultBeanAccessor
>> ---------------------------------------------------------
>>
>>                  Key: SANDBOX-389
>>                  URL: https://issues.apache.org/jira/browse/SANDBOX-389
>>              Project: Commons Sandbox
>>           Issue Type: Improvement
>>           Components: BeanUtils2
>>     Affects Versions: Nightly Builds
>>             Reporter: Benedikt Ritter
>>             Assignee: Simone Tripodi
>>          Attachments: SANDBOX-389.txt, SANDBOX-389v2.txt
>>
>>
>> Implement {{populate()}} as discussed on the ML (see http://markmail.org/thread/niv47muvrms56pqr)
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [jira] [Resolved] (SANDBOX-389) [BeanUtils2] Implement populate() on DefaultBeanAccessor

Posted by Felix Müller <fe...@googlemail.com>.
Hi Benedikt,

at Eclipse you can change tabs to spaces for xml files under: Preferences
-> XML -> Editor. And there "Indent using spaces", best you set it to 2
(most common imho).

-- Felix

2012/2/13 Benedikt Ritter <be...@systemoutprintln.de>

> Hi Simo,
>
> thanks for applying my patches!
>
> Sorry about the license header position. You told me that twice. Stupid
> eclipse does not understand that it has to put the imports under the
> license. I'll pay more attention to that.
>
> And sorry about the tabs in pom.xml. I've configured eclipse to use spaces
> only. Sadly that does just affect the Java editor. Do you know a way to
> configure the pom source editor to use spaces instead of tabs?
>
> About commons-lang version: your right, having a version property does
> only make sense when you're using several components of one vendor (like
> spring framework)
>
> Have a nice start into the new week!
> Benedikt
>
> Am 13.02.2012 23:35, schrieb Simone Tripodi (Resolved) (JIRA):
>
>>
>>      [ https://issues.apache.org/**jira/browse/SANDBOX-389?page=**
>> com.atlassian.jira.plugin.**system.issuetabpanels:all-**tabpanel<https://issues.apache.org/jira/browse/SANDBOX-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel>]
>>
>> Simone Tripodi resolved SANDBOX-389.
>> ------------------------------**------
>>
>>     Resolution: Fixed
>>       Assignee: Simone Tripodi
>>
>> Patch applied, see [r1243720|http://svn.apache.**
>> org/viewvc?rev=1243720&view=**rev<http://svn.apache.org/viewvc?rev=1243720&view=rev>]
>> but please:
>>
>>  * pay attention on new files where license header is located, its proper
>> location is {{before}} the import statements
>>
>>  * inverted logic in {{continue}} statements;
>>
>>  * *NO TABS* in pom XML;
>>
>>  * why did you think putting the {{commons-lang}} version as property
>> would be a benefit?
>>
>>  [BeanUtils2] Implement populate() on DefaultBeanAccessor
>>> ------------------------------**---------------------------
>>>
>>>                 Key: SANDBOX-389
>>>                 URL: https://issues.apache.org/**jira/browse/SANDBOX-389<https://issues.apache.org/jira/browse/SANDBOX-389>
>>>             Project: Commons Sandbox
>>>          Issue Type: Improvement
>>>          Components: BeanUtils2
>>>    Affects Versions: Nightly Builds
>>>            Reporter: Benedikt Ritter
>>>            Assignee: Simone Tripodi
>>>         Attachments: SANDBOX-389.txt, SANDBOX-389v2.txt
>>>
>>>
>>> Implement {{populate()}} as discussed on the ML (see
>>> http://markmail.org/thread/**niv47muvrms56pqr<http://markmail.org/thread/niv47muvrms56pqr>
>>> )
>>>
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA
>> administrators: https://issues.apache.org/**jira/secure/**
>> ContactAdministrators!default.**jspa<https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa>
>> For more information on JIRA, see: http://www.atlassian.com/**
>> software/jira <http://www.atlassian.com/software/jira>
>>
>>
>>
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: dev-unsubscribe@commons.**apache.org<de...@commons.apache.org>
> For additional commands, e-mail: dev-help@commons.apache.org
>
>