You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by lh...@apache.org on 2024/01/15 15:21:41 UTC

(pulsar-helm-chart) branch master updated: Fail the chart-testing job if linting fails (#429)

This is an automated email from the ASF dual-hosted git repository.

lhotari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git


The following commit(s) were added to refs/heads/master by this push:
     new 62569f4  Fail the chart-testing job if linting fails (#429)
62569f4 is described below

commit 62569f4023b9cc30819d2ab89f792900dd09efdd
Author: Lari Hotari <lh...@users.noreply.github.com>
AuthorDate: Mon Jan 15 07:21:35 2024 -0800

    Fail the chart-testing job if linting fails (#429)
---
 .github/workflows/pulsar-helm-chart-ci.yaml | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/.github/workflows/pulsar-helm-chart-ci.yaml b/.github/workflows/pulsar-helm-chart-ci.yaml
index ecf5735..8778186 100644
--- a/.github/workflows/pulsar-helm-chart-ci.yaml
+++ b/.github/workflows/pulsar-helm-chart-ci.yaml
@@ -86,8 +86,6 @@ jobs:
     runs-on: ubuntu-22.04
     timeout-minutes: 45
     if: ${{ needs.preconditions.outputs.docs_only != 'true' }}
-    outputs:
-      no_chart_changes: ${{ steps.ct-lint.outputs.no_chart_changes }}
     steps:
       - name: checkout
         uses: actions/checkout@v4
@@ -127,16 +125,7 @@ jobs:
         run: |
           ct lint --check-version-increment=false \
             --validate-maintainers=false \
-            --target-branch ${{ github.event.repository.default_branch }} \
-            | tee /tmp/ct-lint.log || { 
-            if grep -q "No chart changes detected." /tmp/ct-lint.log; then
-              echo no_chart_changes=true >> $GITHUB_OUTPUT
-              exit 0
-            else
-              echo no_chart_changes=false >> $GITHUB_OUTPUT
-              exit 1
-            fi
-          }
+            --target-branch ${{ github.event.repository.default_branch }}
 
       - name: Wait for ssh connection when build fails
         # ssh access is enabled for builds in own forks