You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/11/08 03:46:35 UTC

[GitHub] [inlong] thesumery commented on a diff in pull request #6424: [INLONG-6409][Sort] Unspported Time and Timestamp iceberg auto create table in spark session query

thesumery commented on code in PR #6424:
URL: https://github.com/apache/inlong/pull/6424#discussion_r1016115407


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/format/DebeziumJsonDynamicSchemaFormat.java:
##########
@@ -44,7 +44,6 @@
  */
 public class DebeziumJsonDynamicSchemaFormat extends JsonDynamicSchemaFormat {
 
-    private static final String IDENTIFIER = "debezium-json";

Review Comment:
   'IDENTIFIER' is used for distinguish different DynamicSchemaFormat，but 'map<String, ?>'  keys can achieve the same goal. Here if want to keep 'IDENTIFIER', must modify getIdentifier to static function because it is private.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org