[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1025: Use clang-tidy instead of cppcheck

[GitBox <gi...@apache.org>]

PragmaTwice commented on PR #1025:
URL: https://github.com/apache/incubator-kvrocks/pull/1025#issuecomment-1287228026

   > May I ask do the comments here also need to be modified? https://github.com/apache/incubator-kvrocks/blob/unstable/src/common/event_util.h#L47
   > 
   > ```
   > struct UniqueEvbufReadln : UniqueFreePtr<char[]> {
   >   // cppcheck-suppress uninitMemberVar
   >   UniqueEvbufReadln(evbuffer *buffer, evbuffer_eol_style eol_style)
   >       : UniqueFreePtr(evbuffer_readln(buffer, &length, eol_style)) {}
   > 
   >   size_t length;
   > };
   > ```
   
   Sure, we can remove the suppression.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org