[GitHub] sijie commented on a change in pull request #1869: adding CmdFunctions unit tests and clean up

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #1869: adding CmdFunctions unit tests and clean up
URL: https://github.com/apache/incubator-pulsar/pull/1869#discussion_r192238194
 
 

 ##########
 File path: pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/CmdFunctionsTest.java
 ##########
 @@ -124,16 +129,16 @@ public void setup() throws Exception {
         when(Reflections.createInstance(eq(DefaultSerDe.class.getName()), any(File.class))).thenReturn(new DefaultSerDe(String.class));
     }
 
-    @Test
-    public void testLocalRunnerCmdNoArguments() throws Exception {
-        cmd.run(new String[] { "run" });
-
-        LocalRunner runner = cmd.getLocalRunner();
-        assertNull(runner.getFunctionName());
-        assertNull(runner.getInputs());
-        assertNull(runner.getOutput());
-        assertNull(runner.getFnConfigFile());
-    }
+//    @Test
 
 Review comment:
   nit: if this is not needed, remove the code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services