You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Andy Yang (JIRA)" <ji...@apache.org> on 2017/09/10 17:06:02 UTC
[jira] [Comment Edited] (HBASE-13844) Move static helper methods
from KeyValue into CellUtils
[ https://issues.apache.org/jira/browse/HBASE-13844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160408#comment-16160408 ]
Andy Yang edited comment on HBASE-13844 at 9/10/17 5:05 PM:
------------------------------------------------------------
I cleaned the deprecated codes in the KeyValue object.
When I replaced the following objects to corresponding objects. I found those corresponding objects don't have the getLegacyKeyComparatorName() method and an object need this function (org.apache.hadoop.hbase.io.hfile.FixedFileTrailer).
{code:java}
/**
* Comparator for plain key/values; i.e. non-catalog table key/values. Works on Key portion
* of KeyValue only.
* @deprecated Use {@link CellComparator#COMPARATOR} instead
*/
@Deprecated
public static final KVComparator COMPARATOR = new KVComparator();
/**
* A {@link KVComparator} for <code>hbase:meta</code> catalog table
* {@link KeyValue}s.
* @deprecated Use {@link CellComparator#META_COMPARATOR} instead
*/
@Deprecated
public static final KVComparator META_COMPARATOR = new MetaComparator();
/**
* Needed for Bloom Filters.
* * @deprecated Use {@link Bytes#BYTES_RAWCOMPARATOR} instead
*/
@Deprecated
public static final KVComparator RAW_COMPARATOR = new RawBytesComparator();
{code}
So I am not sure if we need to add getLegacyKeyComparatorName() to those corresponding objects (CellComparator#COMPARATOR, CellComparator#META_COMPARATOR, and Bytes#BYTES_RAWCOMPARATOR) ?
was (Author: andy7904):
I cleaned the deprecated codes in the KeyValue object.
When I replaced the following objects to corresponding objects. I found those corresponding objects don't have the getLegacyKeyComparatorName() method and some objects need this function (org.apache.hadoop.hbase.io.hfile.FixedFileTrailer).
{code:java}
/**
* Comparator for plain key/values; i.e. non-catalog table key/values. Works on Key portion
* of KeyValue only.
* @deprecated Use {@link CellComparator#COMPARATOR} instead
*/
@Deprecated
public static final KVComparator COMPARATOR = new KVComparator();
/**
* A {@link KVComparator} for <code>hbase:meta</code> catalog table
* {@link KeyValue}s.
* @deprecated Use {@link CellComparator#META_COMPARATOR} instead
*/
@Deprecated
public static final KVComparator META_COMPARATOR = new MetaComparator();
/**
* Needed for Bloom Filters.
* * @deprecated Use {@link Bytes#BYTES_RAWCOMPARATOR} instead
*/
@Deprecated
public static final KVComparator RAW_COMPARATOR = new RawBytesComparator();
{code}
So I am not sure if we need to add getLegacyKeyComparatorName() to those corresponding objects (CellComparator#COMPARATOR, CellComparator#META_COMPARATOR, and Bytes#BYTES_RAWCOMPARATOR) ?
> Move static helper methods from KeyValue into CellUtils
> -------------------------------------------------------
>
> Key: HBASE-13844
> URL: https://issues.apache.org/jira/browse/HBASE-13844
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 1.1.0
> Reporter: Lars George
> Assignee: Andy Yang
> Priority: Minor
> Labels: beginner
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-13844.1.patch, HBASE-13844.2.patch, HBASE-13844.3.patch
>
>
> Add KeyValue.parseColumn() to CellUtils (also any other public static helper)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)