[GitHub] [geode] bschuchardt opened pull request #2717: GEODE-5925 Server shutdown delays election of new primary bucket owners

["bschuchardt (GitHub)" <gi...@apache.org>]

This PR addresses the problem of AcceptorImpl sending out expensive
profile update messages when it's being stopped during Cache.close().
There is no reason to send these messages if the affected regions are
going to be destroyed since that also sends profile updates
to other members of the cluster.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2717 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt closed pull request #2717: GEODE-5925 Server shutdown delays election of new primary bucket owners

["bschuchardt (GitHub)" <gi...@apache.org>]

[ pull request closed by bschuchardt ]

[ Full content available at: https://github.com/apache/geode/pull/2717 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jhuynh1 commented on pull request #2717: GEODE-5925 Server shutdown delays election of new primary bucket owners

["jhuynh1 (GitHub)" <gi...@apache.org>]

With the changes to AllBucketProfilesUpdateMessage, would we be able to remove this check - isn't a reply always being returned now?

[ Full content available at: https://github.com/apache/geode/pull/2717 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] agingade commented on pull request #2717: GEODE-5925 Server shutdown delays election of new primary bucket owners

["agingade (GitHub)" <gi...@apache.org>]

I am not sure why we are sending PR bucket profiles when we start and stop the cache server. But since we are not sending cache profile during cache-server stop; during cache.close(); do we need to send the profiles during start?

[ Full content available at: https://github.com/apache/geode/pull/2717 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt commented on pull request #2717: GEODE-5925 Server shutdown delays election of new primary bucket owners

["bschuchardt (GitHub)" <gi...@apache.org>]

Thanks Jason - I'll remove that

[ Full content available at: https://github.com/apache/geode/pull/2717 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org