You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by us...@apache.org on 2014/11/21 09:28:15 UTC
svn commit: r1640876 - /lucene/dev/trunk/lucene/common-build.xml
Author: uschindler
Date: Fri Nov 21 08:28:14 2014
New Revision: 1640876
URL: http://svn.apache.org/r1640876
Log:
LUCENE-5950: Remove Javadocs patcher (no longer needed with Java 8 minimum)
Modified:
lucene/dev/trunk/lucene/common-build.xml
Modified: lucene/dev/trunk/lucene/common-build.xml
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/common-build.xml?rev=1640876&r1=1640875&r2=1640876&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/common-build.xml (original)
+++ lucene/dev/trunk/lucene/common-build.xml Fri Nov 21 08:28:14 2014
@@ -2042,72 +2042,9 @@ ${ant.project.name}.test.dependencies=${
</and>
</condition>
</fail>
-
- <patch-javadoc dir="@{destdir}" docencoding="${javadoc.charset}"/>
</sequential>
</macrodef>
- <!--
- Patch frame injection bugs in javadoc generated files - see CVE-2013-1571, http://www.kb.cert.org/vuls/id/225657
-
- Feel free to use this macro in your own Ant build file. This macro works together with the javadoc task on Ant
- and should be invoked directly after its execution to patch broken javadocs, e.g.:
- <patch-javadoc dir="..." docencoding="UTF-8"/>
- Please make sure that the docencoding parameter uses the same charset like javadoc's docencoding. Default
- is the platform default encoding (like the javadoc task).
- The specified dir is the destination directory of the javadoc task.
- -->
- <macrodef name="patch-javadoc">
- <attribute name="dir"/>
- <attribute name="docencoding" default="${file.encoding}"/>
- <sequential>
- <replace encoding="@{docencoding}" summary="true" taskname="patch-javadoc">
- <fileset dir="@{dir}" casesensitive="false" includes="**/index.html,**/index.htm,**/toc.html,**/toc.htm">
- <!-- TODO: add encoding="@{docencoding}" to contains check, when we are on ANT 1.9.0: -->
- <not><contains text="function validURL(url) {" casesensitive="true" /></not>
- </fileset>
- <replacetoken><![CDATA[function loadFrames() {]]></replacetoken>
- <replacevalue expandProperties="false"><![CDATA[if (targetPage != "" && !validURL(targetPage))
- targetPage = "undefined";
- function validURL(url) {
- var pos = url.indexOf(".html");
- if (pos == -1 || pos != url.length - 5)
- return false;
- var allowNumber = false;
- var allowSep = false;
- var seenDot = false;
- for (var i = 0; i < url.length - 5; i++) {
- var ch = url.charAt(i);
- if ('a' <= ch && ch <= 'z' ||
- 'A' <= ch && ch <= 'Z' ||
- ch == '$' ||
- ch == '_') {
- allowNumber = true;
- allowSep = true;
- } else if ('0' <= ch && ch <= '9'
- || ch == '-') {
- if (!allowNumber)
- return false;
- } else if (ch == '/' || ch == '.') {
- if (!allowSep)
- return false;
- allowNumber = false;
- allowSep = false;
- if (ch == '.')
- seenDot = true;
- if (ch == '/' && seenDot)
- return false;
- } else {
- return false;
- }
- }
- return true;
- }
- function loadFrames() {]]></replacevalue>
- </replace>
- </sequential>
- </macrodef>
-
<target name="check-javadocs-uptodate">
<uptodate property="javadocs-uptodate-${name}" targetfile="${build.dir}/${final.name}-javadoc.jar">
<srcfiles dir="${src.dir}">