You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/11/13 16:10:38 UTC
[GitHub] [solr] gerlowskija opened a new pull request #415: SOLR-15792: Rewrite shardname APIs using annotation framework
gerlowskija opened a new pull request #415:
URL: https://github.com/apache/solr/pull/415
# Description
Rewrites several /v2/collections/collName/shards/shardName APIs from their existing "apispec" based implementation, over to a new annotation-framework based approach.
# Solution
The APIs ("delete-shard", "force-leader", and "sync-shard") are given their own "API" classes registered with the ApiBag owned by Solr's CoreContainer. These API classes mostly just shuffle parameters around before calling the existing code that implements the v1 versions of these APIs. "Payload" classes are added for the POST-body used by force-leader and sync-shard.
# Tests
None, yet.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #415: SOLR-15792: Rewrite shardname APIs using annotation framework
Posted by GitBox <gi...@apache.org>.
gerlowskija merged pull request #415:
URL: https://github.com/apache/solr/pull/415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org