You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/01/27 14:48:26 UTC
[GitHub] [camel-kamelets] squakez opened a new pull request #750: chore: move deprecated flow to template
squakez opened a new pull request #750:
URL: https://github.com/apache/camel-kamelets/pull/750
This PR span over all the list of Kamelets as we've deprecated since a while `.spec.flow` parameter in favour of `.spec.template`. https://github.com/apache/camel-k/pull/2932 will remove it from next `camel-k` spec (1.9), so we must apply this change before that PR is merged as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] squakez commented on pull request #750: chore: move deprecated flow to template
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #750:
URL: https://github.com/apache/camel-kamelets/pull/750#issuecomment-1023287612
By the way, I'm not sure if there is any other documentation, apart the autogenerated one from the same sources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] squakez commented on pull request #750: chore: move deprecated flow to template
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #750:
URL: https://github.com/apache/camel-kamelets/pull/750#issuecomment-1024080082
No problem. I was planning to close it anyway or rebase after #751 is fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #750: chore: move deprecated flow to template
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #750:
URL: https://github.com/apache/camel-kamelets/pull/750#issuecomment-1024025802
Sorry I had to revert. We have multiple place where we need to address this:
- the catalog is using the camel-k extension from fabric8 kubernetes-client and there is no trace of spec.template directly there
- the validator needs to point to an updated model for camel-k crd etc. and still we cannot use it
- in this situation test on catalog will fail, validation will fail etc.
- We could leave the PR open @squakez and wait for a more stable situation for updating main here, can you place create a new PR? Thanks and sorry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] djencks commented on pull request #750: chore: move deprecated flow to template
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #750:
URL: https://github.com/apache/camel-kamelets/pull/750#issuecomment-1023729298
At least https://camel.apache.org/camel-k/next/kamelets/kamelets-dev.html has `flow` in the samples. I didn't look in your other PRs, I'll plan to fix this if you haven't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] djencks edited a comment on pull request #750: chore: move deprecated flow to template
Posted by GitBox <gi...@apache.org>.
djencks edited a comment on pull request #750:
URL: https://github.com/apache/camel-kamelets/pull/750#issuecomment-1023729298
At least https://camel.apache.org/camel-k/next/kamelets/kamelets-dev.html has `flow` in the samples. I didn't look in your other PRs, I'll plan to fix this if you haven't.
... I see you already fixed this in the camel-k PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #750: chore: move deprecated flow to template
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #750:
URL: https://github.com/apache/camel-kamelets/pull/750#issuecomment-1024019188
Let's merge this one for beginning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd merged pull request #750: chore: move deprecated flow to template
Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #750:
URL: https://github.com/apache/camel-kamelets/pull/750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] squakez commented on pull request #750: chore: move deprecated flow to template
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #750:
URL: https://github.com/apache/camel-kamelets/pull/750#issuecomment-1023369644
The validation is failing #751. Will need to fix it along this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org