You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2015/12/09 17:55:16 UTC

svn commit: r1718905 - /tomcat/native/trunk/native/srclib/VERSIONS

Author: markt
Date: Wed Dec  9 16:55:16 2015
New Revision: 1718905

URL: http://svn.apache.org/viewvc?rev=1718905&view=rev
Log:
Revert back to APR 1.5.1. I can't get 1.5.2 to build for the Windows release.

Modified:
    tomcat/native/trunk/native/srclib/VERSIONS

Modified: tomcat/native/trunk/native/srclib/VERSIONS
URL: http://svn.apache.org/viewvc/tomcat/native/trunk/native/srclib/VERSIONS?rev=1718905&r1=1718904&r2=1718905&view=diff
==============================================================================
--- tomcat/native/trunk/native/srclib/VERSIONS (original)
+++ tomcat/native/trunk/native/srclib/VERSIONS Wed Dec  9 16:55:16 2015
@@ -1,4 +1,4 @@
 Use the following version of the libraries
 
-- APR 1.5.2, http://apr.apache.org
+- APR 1.5.1, http://apr.apache.org
 - OpenSSL 1.0.2e or later, http://www.openssl.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1718905 - /tomcat/native/trunk/native/srclib/VERSIONS

Posted by Mark Thomas <ma...@apache.org>.
On 09/12/2015 17:17, Konstantin Kolinko wrote:
> So the build may need linking to rpcrt4  now.

Thanks for the hint. That wasn't it but I have figured out the problem.

We only build the sub-set of APR that we need. Between 1.5.1 and 1.5.2
that subset gained a dependency on encoding\apr_escape.c which we need
to add to our NMAKEmakefile. I figured out how to do that (I think) but
encoding\apr_escape.c has a dependency on a header file that is auto
generated during the APR build (apr_escape_test_char.h). I haven't been
able to figure out how to add that to the make file.

I also confirmed removing the code that now depends on apr_escape.c is
not an option.

We need someone who knows their way around a C build script better than
I do to fix this.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1718905 - /tomcat/native/trunk/native/srclib/VERSIONS

Posted by Konstantin Kolinko <kn...@gmail.com>.
2015-12-09 20:09 GMT+03:00 Mark Thomas <ma...@apache.org>:
> On 09/12/2015 17:03, Konstantin Kolinko wrote:
>> 2015-12-09 19:55 GMT+03:00  <ma...@apache.org>:
>>> Author: markt
>>> Date: Wed Dec  9 16:55:16 2015
>>> New Revision: 1718905
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1718905&view=rev
>>> Log:
>>> Revert back to APR 1.5.1. I can't get 1.5.2 to build for the Windows release.
>>>
>>> Modified:
>>>     tomcat/native/trunk/native/srclib/VERSIONS
>>>
>>> Modified: tomcat/native/trunk/native/srclib/VERSIONS
>>> URL: http://svn.apache.org/viewvc/tomcat/native/trunk/native/srclib/VERSIONS?rev=1718905&r1=1718904&r2=1718905&view=diff
>>> ==============================================================================
>>> --- tomcat/native/trunk/native/srclib/VERSIONS (original)
>>> +++ tomcat/native/trunk/native/srclib/VERSIONS Wed Dec  9 16:55:16 2015
>>> @@ -1,4 +1,4 @@
>>>  Use the following version of the libraries
>>>
>>> -- APR 1.5.2, http://apr.apache.org
>>> +- APR 1.5.1, http://apr.apache.org
>>>  - OpenSSL 1.0.2e or later, http://www.openssl.org
>>
>>
>> What is the error here?
>
> I don't recall the details off the top of my head. It was a linking
> error of some form.
>
> I'll have to run the build with 1.5.2 to get the exact error. I want to
> get the RCs complete first.
>
> Mark
>
>>
>> Changelog for 1.5.2:
>> http://www.apache.org/dist/apr/CHANGES-APR-1.5
>>

Changelog includes the following entry:

  *) Potential Windows build consideration: The increased use of
     UuidCreate() in APR may introduce a link error for applications
     which link with apr-1.lib.  Include the Windows library rpcrt4 if
     linking fails with an unresolved reference to UuidCreate().


So the build may need linking to rpcrt4  now.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1718905 - /tomcat/native/trunk/native/srclib/VERSIONS

Posted by Mark Thomas <ma...@apache.org>.
On 09/12/2015 17:03, Konstantin Kolinko wrote:
> 2015-12-09 19:55 GMT+03:00  <ma...@apache.org>:
>> Author: markt
>> Date: Wed Dec  9 16:55:16 2015
>> New Revision: 1718905
>>
>> URL: http://svn.apache.org/viewvc?rev=1718905&view=rev
>> Log:
>> Revert back to APR 1.5.1. I can't get 1.5.2 to build for the Windows release.
>>
>> Modified:
>>     tomcat/native/trunk/native/srclib/VERSIONS
>>
>> Modified: tomcat/native/trunk/native/srclib/VERSIONS
>> URL: http://svn.apache.org/viewvc/tomcat/native/trunk/native/srclib/VERSIONS?rev=1718905&r1=1718904&r2=1718905&view=diff
>> ==============================================================================
>> --- tomcat/native/trunk/native/srclib/VERSIONS (original)
>> +++ tomcat/native/trunk/native/srclib/VERSIONS Wed Dec  9 16:55:16 2015
>> @@ -1,4 +1,4 @@
>>  Use the following version of the libraries
>>
>> -- APR 1.5.2, http://apr.apache.org
>> +- APR 1.5.1, http://apr.apache.org
>>  - OpenSSL 1.0.2e or later, http://www.openssl.org
> 
> 
> What is the error here?

I don't recall the details off the top of my head. It was a linking
error of some form.

I'll have to run the build with 1.5.2 to get the exact error. I want to
get the RCs complete first.

Mark

> 
> Changelog for 1.5.2:
> http://www.apache.org/dist/apr/CHANGES-APR-1.5
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1718905 - /tomcat/native/trunk/native/srclib/VERSIONS

Posted by Konstantin Kolinko <kn...@gmail.com>.
2015-12-09 19:55 GMT+03:00  <ma...@apache.org>:
> Author: markt
> Date: Wed Dec  9 16:55:16 2015
> New Revision: 1718905
>
> URL: http://svn.apache.org/viewvc?rev=1718905&view=rev
> Log:
> Revert back to APR 1.5.1. I can't get 1.5.2 to build for the Windows release.
>
> Modified:
>     tomcat/native/trunk/native/srclib/VERSIONS
>
> Modified: tomcat/native/trunk/native/srclib/VERSIONS
> URL: http://svn.apache.org/viewvc/tomcat/native/trunk/native/srclib/VERSIONS?rev=1718905&r1=1718904&r2=1718905&view=diff
> ==============================================================================
> --- tomcat/native/trunk/native/srclib/VERSIONS (original)
> +++ tomcat/native/trunk/native/srclib/VERSIONS Wed Dec  9 16:55:16 2015
> @@ -1,4 +1,4 @@
>  Use the following version of the libraries
>
> -- APR 1.5.2, http://apr.apache.org
> +- APR 1.5.1, http://apr.apache.org
>  - OpenSSL 1.0.2e or later, http://www.openssl.org


What is the error here?

Changelog for 1.5.2:
http://www.apache.org/dist/apr/CHANGES-APR-1.5

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org