You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/11/02 11:59:45 UTC
[GitHub] [incubator-livy] codecov-io edited a comment on issue #249:
[LIVY-702]: Submit Spark apps to Kubernetes
codecov-io edited a comment on issue #249: [LIVY-702]: Submit Spark apps to Kubernetes
URL: https://github.com/apache/incubator-livy/pull/249#issuecomment-546723412
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/249?src=pr&el=h1) Report
> Merging [#249](https://codecov.io/gh/apache/incubator-livy/pull/249?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/ba12b51ec987e76b6b67e20f60b4326e203b03f6?src=pr&el=desc) will **decrease** coverage by `1.67%`.
> The diff coverage is `35.76%`.
[](https://codecov.io/gh/apache/incubator-livy/pull/249?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #249 +/- ##
============================================
- Coverage 68.06% 66.39% -1.68%
- Complexity 940 956 +16
============================================
Files 101 103 +2
Lines 5855 6174 +319
Branches 886 943 +57
============================================
+ Hits 3985 4099 +114
- Misses 1299 1482 +183
- Partials 571 593 +22
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/249?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `80.08% <0%> (-0.68%)` | `45 <0> (-1)` | |
| [rsc/src/main/java/org/apache/livy/rsc/RSCConf.java](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9SU0NDb25mLmphdmE=) | `88.18% <100%> (+0.33%)` | `9 <1> (+1)` | :arrow_up: |
| [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `96.33% <100%> (+0.35%)` | `23 <2> (+2)` | :arrow_up: |
| [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `32.88% <20%> (ø)` | `11 <1> (ø)` | :arrow_down: |
| [...e/livy/server/interactive/InteractiveSession.scala](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvaW50ZXJhY3RpdmUvSW50ZXJhY3RpdmVTZXNzaW9uLnNjYWxh) | `68.93% <33.33%> (-0.44%)` | `46 <0> (ø)` | |
| [...ala/org/apache/livy/utils/SparkKubernetesApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya0t1YmVybmV0ZXNBcHAuc2NhbGE=) | `33.46% <33.46%> (ø)` | `14 <14> (?)` | |
| [...rc/main/scala/org/apache/livy/utils/SparkApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya0FwcC5zY2FsYQ==) | `45.23% <5.55%> (-30.77%)` | `1 <0> (ø)` | |
| [...c/main/scala/org/apache/livy/repl/ReplDriver.scala](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-cmVwbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvcmVwbC9SZXBsRHJpdmVyLnNjYWxh) | `30.76% <0%> (-2.57%)` | `7% <0%> (ø)` | |
| [...vy/server/auth/LdapAuthenticationHandlerImpl.scala](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvYXV0aC9MZGFwQXV0aGVudGljYXRpb25IYW5kbGVySW1wbC5zY2FsYQ==) | `55.67% <0%> (-0.65%)` | `13% <0%> (ø)` | |
| [.../scala/org/apache/livy/server/auth/LdapUtils.scala](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvYXV0aC9MZGFwVXRpbHMuc2NhbGE=) | `20% <0%> (ø)` | `0% <0%> (?)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-livy/pull/249/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/249?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/249?src=pr&el=footer). Last update [ba12b51...085b7a6](https://codecov.io/gh/apache/incubator-livy/pull/249?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services