You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/13 15:53:06 UTC
[GitHub] [superset] pkdotson opened a new pull request #16689: chore: refactor header menu to show in header grid component
pkdotson opened a new pull request #16689:
URL: https://github.com/apache/superset/pull/16689
### SUMMARY
This pr removes the hovermenu less file and refactors code to show the dashboard hover menu delete icon inside the header.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
https://user-images.githubusercontent.com/17326228/133115922-7670a640-18f5-4649-abc5-38920d63a3c0.mov
after
https://user-images.githubusercontent.com/17326228/133116020-c83fc7a5-20c9-4a6f-a79c-c22472f688b5.mov
### TESTING INSTRUCTIONS
Go to a dashboard and click on edit. Next drag a header tab to dashboard and ensure that the delete button show up on hover.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x ] Has associated issue: Fixes https://github.com/apache/superset/issues/16424
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-918727815
> We got this feedback from a first time user feeback so we suggest that
> 1, to make trashcan icon show when hovering over for all components
> 2, when trashcan icon show for header and markdown, it will show in the right top conner inside the component so that it is clear to the user what is deleting.
based on your comment, this PR didn't do it correctly. it removed font-size and background menu, is it part of design?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-919233334
@pkdotson Ephemeral environment spinning up at http://54.245.135.47:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-918358046
# [Codecov](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16689](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74192e4) into [master](https://codecov.io/gh/apache/superset/commit/4b70d46355c3018a516e1cb68c3d4a23004402ad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b70d46) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 74192e4 differs from pull request most recent head 51b4ed1. Consider uploading reports for the commit 51b4ed1 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16689 +/- ##
=======================================
Coverage 76.88% 76.88%
=======================================
Files 1005 1005
Lines 54005 54014 +9
Branches 7337 7341 +4
=======================================
+ Hits 41522 41529 +7
- Misses 12243 12245 +2
Partials 240 240
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.28% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/components/DashboardBuilder/DashboardBuilder.tsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQnVpbGRlci50c3g=) | `90.17% <ø> (ø)` | |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `100.00% <100.00%> (ø)` | |
| [...ontend/src/dashboard/components/menu/HoverMenu.tsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvSG92ZXJNZW51LnRzeA==) | `90.00% <100.00%> (-10.00%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `85.71% <0.00%> (-0.96%)` | :arrow_down: |
| [...nd/src/dashboard/components/gridComponents/Row.jsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1Jvdy5qc3g=) | `86.66% <0.00%> (ø)` | |
| [...nd/src/dashboard/containers/DashboardComponent.jsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZENvbXBvbmVudC5qc3g=) | `100.00% <0.00%> (ø)` | |
| [...src/dashboard/components/gridComponents/Column.jsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NvbHVtbi5qc3g=) | `87.87% <0.00%> (ø)` | |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `69.81% <0.00%> (+0.50%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4b70d46...51b4ed1](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa edited a comment on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
jinghua-qa edited a comment on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-919365797
> > We got this feedback from a first time user feeback so we suggest that
> > 1, to make trashcan icon show when hovering over for all components
> > 2, when trashcan icon show for header and markdown, it will show in the right top conner inside the component so that it is clear to the user what is deleting.
>
> based on your comment, this PR didn't do it correctly. it removed font-size and background menu, is it part of design?
@graceguo-supercat I tried in the test env, the font-size and background menu will show by click in header. Is our plan to change the trashcan to show by hovering over in header and markdown sound good to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-918700712
@graceguo-supercat, we want to make this change because of 2 reasons:
1, For header and markdown component, the trashcan icon is not shown when hovering over (shown by click), which is inconsistent behavior with the rest of other dashboard components.
2,This inconsistent behavior sometimes could cause confusion. For example, when we have a markdown in a row, when user hovering over the markdown, a trashcan icon will show because of the Row component and makes user think that icon is to delete the markdown, but clicking on that trash icon will delete the Row with all components because the trash icon is shown when hovering a row and markdown trash icon wont show until you click on it.
We got this feedback from a first time user feeback so we suggest that
1, to make trashcan icon show when hovering over for all components
2, when trashcan icon show for header and markdown, it will show in the right top conner inside the component so that it is clear to the user what is deleting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-918727815
> We got this feedback from a first time user feeback so we suggest that
> 1, to make trashcan icon show when hovering over for all components
> 2, when trashcan icon show for header and markdown, it will show in the right top conner inside the component so that it is clear to the user what is deleting.
based on your comment, this PR didn't do it correctly. it removed font-size and background menu, is it part of design?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-919365797
> > We got this feedback from a first time user feeback so we suggest that
> > 1, to make trashcan icon show when hovering over for all components
> > 2, when trashcan icon show for header and markdown, it will show in the right top conner inside the component so that it is clear to the user what is deleting.
>
> based on your comment, this PR didn't do it correctly. it removed font-size and background menu, is it part of design?
> > We got this feedback from a first time user feeback so we suggest that
> > 1, to make trashcan icon show when hovering over for all components
> > 2, when trashcan icon show for header and markdown, it will show in the right top conner inside the component so that it is clear to the user what is deleting.
>
> based on your comment, this PR didn't do it correctly. it removed font-size and background menu, is it part of design?
@graceguo-supercat I tried in the test env, the font-size and background menu will show by click. Is our plan to change the trashcan to show by hovering over in header and markdown sound good to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-919606133
before: click to show UI menu + trash icon
after: click to show UI menu, but hove to show trash icon
Do you really need to make this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
pkdotson commented on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-919233095
> > We got this feedback from a first time user feeback so we suggest that
> > 1, to make trashcan icon show when hovering over for all components
> > 2, when trashcan icon show for header and markdown, it will show in the right top conner inside the component so that it is clear to the user what is deleting.
>
> based on your comment, this PR didn't do it correctly. it removed font-size and background menu, is it part of design?
@graceguo-supercat font size and background menu is still there. You have to click on the grid component to have them show like you do in markdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
pkdotson commented on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-919231648
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-918665933
May I know why do you want to remove extra menu/options for dashboard header?
cc @junlincc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-933870737
@pkdotson Ephemeral environment spinning up at http://35.85.65.49:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
pkdotson commented on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-933868093
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-918358046
# [Codecov](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16689](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51b4ed1) into [master](https://codecov.io/gh/apache/superset/commit/4b70d46355c3018a516e1cb68c3d4a23004402ad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b70d46) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16689 +/- ##
=======================================
Coverage 76.88% 76.89%
=======================================
Files 1005 1005
Lines 54005 54061 +56
Branches 7337 7376 +39
=======================================
+ Hits 41522 41568 +46
- Misses 12243 12253 +10
Partials 240 240
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.30% <100.00%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/components/DashboardBuilder/DashboardBuilder.tsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQnVpbGRlci50c3g=) | `90.17% <ø> (ø)` | |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `83.16% <ø> (ø)` | |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `100.00% <100.00%> (ø)` | |
| [...ontend/src/dashboard/components/menu/HoverMenu.tsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvSG92ZXJNZW51LnRzeA==) | `90.00% <100.00%> (-10.00%)` | :arrow_down: |
| [superset-frontend/src/logger/LogUtils.ts](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2xvZ2dlci9Mb2dVdGlscy50cw==) | `84.00% <0.00%> (-7.31%)` | :arrow_down: |
| [...rontend/src/components/Select/DeprecatedSelect.tsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L0RlcHJlY2F0ZWRTZWxlY3QudHN4) | `82.35% <0.00%> (-3.37%)` | :arrow_down: |
| [...uperset-frontend/src/components/Menu/MenuRight.tsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51UmlnaHQudHN4) | `91.22% <0.00%> (-1.23%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `85.71% <0.00%> (-0.96%)` | :arrow_down: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `14.28% <0.00%> (-0.72%)` | :arrow_down: |
| [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `44.13% <0.00%> (-0.12%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4b70d46...51b4ed1](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-919606133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-919606133
before: (both header and markdown) click to show UI menu + trash icon
after:
Header: click to show UI menu, but hove to show trash icon
Markdown: click to show UI menu + trash icon.
Do you really need to make this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson merged pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
pkdotson merged pull request #16689:
URL: https://github.com/apache/superset/pull/16689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-918665933
May I know why do you want to remove extra UI menu/options for dashboard header?
cc @junlincc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-918358046
# [Codecov](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16689](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74192e4) into [master](https://codecov.io/gh/apache/superset/commit/4b70d46355c3018a516e1cb68c3d4a23004402ad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b70d46) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16689 +/- ##
=======================================
Coverage 76.88% 76.88%
=======================================
Files 1005 1005
Lines 54005 54014 +9
Branches 7337 7341 +4
=======================================
+ Hits 41522 41529 +7
- Misses 12243 12245 +2
Partials 240 240
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.28% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/components/DashboardBuilder/DashboardBuilder.tsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQnVpbGRlci50c3g=) | `90.17% <ø> (ø)` | |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `100.00% <100.00%> (ø)` | |
| [...ontend/src/dashboard/components/menu/HoverMenu.tsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvSG92ZXJNZW51LnRzeA==) | `90.00% <100.00%> (-10.00%)` | :arrow_down: |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | `85.71% <0.00%> (-0.96%)` | :arrow_down: |
| [...nd/src/dashboard/components/gridComponents/Row.jsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1Jvdy5qc3g=) | `86.66% <0.00%> (ø)` | |
| [...nd/src/dashboard/containers/DashboardComponent.jsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZENvbXBvbmVudC5qc3g=) | `100.00% <0.00%> (ø)` | |
| [...src/dashboard/components/gridComponents/Column.jsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NvbHVtbi5qc3g=) | `87.87% <0.00%> (ø)` | |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/16689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `69.81% <0.00%> (+0.50%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4b70d46...74192e4](https://codecov.io/gh/apache/superset/pull/16689?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
pkdotson commented on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-921028944
> before: (both header and markdown) click to show UI menu + trash icon
>
> after:
> Header: click to show UI menu, but hove to show trash icon
> Markdown: click to show UI menu + trash icon.
>
> isn't this more _inconsistent_? Do you really need to make this change?
@graceguo-supercat this has been changed as well. The delete now shows in the markdown on hover as well.
<img width="391" alt="Screen Shot 2021-09-15 at 3 00 24 PM" src="https://user-images.githubusercontent.com/17326228/133645563-6d3709a1-2f2b-4cc6-846e-1ca437b3be0f.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-918727815
> We got this feedback from a first time user feeback so we suggest that
> 1, to make trashcan icon show when hovering over for all components
> 2, when trashcan icon show for header and markdown, it will show in the right top conner inside the component so that it is clear to the user what is deleting.
based on your comment, this PR didn't do it correctly. it removed font-size and background menu, is it part of design?
@graceguo-supercat font size and background menu is still there. You have to click on the grid component to have them show like you do in markdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa edited a comment on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
jinghua-qa edited a comment on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-919365797
> > We got this feedback from a first time user feeback so we suggest that
> > 1, to make trashcan icon show when hovering over for all components
> > 2, when trashcan icon show for header and markdown, it will show in the right top conner inside the component so that it is clear to the user what is deleting.
>
> based on your comment, this PR didn't do it correctly. it removed font-size and background menu, is it part of design?
@graceguo-supercat I tried in the test env, the font-size and background menu will show by click. Is our plan to change the trashcan to show by hovering over in header and markdown sound good to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-919358108
@pkdotson I tested in the test env, for header, it is worked as expected: trash icon is showed when hovering over, and the font size and background menu is shown when clicking on the component. But for markdown, the trash icon is not shown inside the component when hover over, it is still shown by clicking.
https://user-images.githubusercontent.com/81597121/133304334-e3e5ff1a-f7a0-4855-808f-dedbe73bbb7d.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-918665933
May I know why do you want to remove extra UI menu/options for dashboard header? Dashboard header and markdown component do have extra UI menu which are not available fro chart. But why is it an issue?
cc @junlincc @jinghua-qa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16689: chore: refactor header menu to show in header grid component
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16689:
URL: https://github.com/apache/superset/pull/16689#issuecomment-933888880
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org