You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/04 18:54:47 UTC

[GitHub] [spark] sarutak opened a new pull request #34172: [SPARK-36874][SQL] DeduplicateRelations should copy dataset_id tag to avoid ambiguous self join

sarutak opened a new pull request #34172:
URL: https://github.com/apache/spark/pull/34172


   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   This PR fixes an issue that ambiguous self join can't be detected if the left and right DataFrame are swapped.
   This is an example.
   ```
   val df1 = Seq((1, 2, "A1"),(2, 1, "A2")).toDF("key1", "key2", "value")
   val df2 = df1.filter($"value" === "A2")
   
   df1.join(df2, df1("key1") === df2("key2")) // Ambiguous self join is detected and AnalysisException is thrown.
   
   df2.join(df1, df1("key1") === df2("key2)) // Ambiguous self join is not detected.
   ```
   
   The root cause seems that an inner function `collectConflictPlans` in `DeduplicateRelations.` doesn't copy the `dataset_id` tag when it copies a `LogicalPlan`.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Bug fix.
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   No.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   New tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #34172: [SPARK-36874][SQL] DeduplicateRelations should copy dataset_id tag to avoid ambiguous self join

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34172:
URL: https://github.com/apache/spark/pull/34172#issuecomment-934024151


   thanks, merging to master/3.2!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun edited a comment on pull request #34172: [SPARK-36874][SQL] DeduplicateRelations should copy dataset_id tag to avoid ambiguous self join

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #34172:
URL: https://github.com/apache/spark/pull/34172#issuecomment-936796592


   Thank you, @sarutak and @cloud-fan . According to the JIRA issue, do we need this at branch-3.1, too?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34172: [SPARK-36874][SQL] DeduplicateRelations should copy dataset_id tag to avoid ambiguous self join

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34172:
URL: https://github.com/apache/spark/pull/34172#issuecomment-933940628


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143819/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34172: [SPARK-36874][SQL] DeduplicateRelations should copy dataset_id tag to avoid ambiguous self join

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34172:
URL: https://github.com/apache/spark/pull/34172#issuecomment-933794193


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48332/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34172: [SPARK-36874][SQL] DeduplicateRelations should copy dataset_id tag to avoid ambiguous self join

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34172:
URL: https://github.com/apache/spark/pull/34172#issuecomment-933837143


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48332/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #34172: [SPARK-36874][SQL] DeduplicateRelations should copy dataset_id tag to avoid ambiguous self join

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34172:
URL: https://github.com/apache/spark/pull/34172#issuecomment-937389544


   @dongjoon-hyun Thank you for letting me know. It seems better to backport. I'll do it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #34172: [SPARK-36874][SQL] DeduplicateRelations should copy dataset_id tag to avoid ambiguous self join

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34172:
URL: https://github.com/apache/spark/pull/34172#issuecomment-936796592


   Thank you, @sarutak and @cloud-fan . Do we need this at branch-3.1, too?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #34172: [SPARK-36874][SQL] DeduplicateRelations should copy dataset_id tag to avoid ambiguous self join

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34172:
URL: https://github.com/apache/spark/pull/34172#issuecomment-933989542


   cc @cloud-fan FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34172: [SPARK-36874][SQL] DeduplicateRelations should copy dataset_id tag to avoid ambiguous self join

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34172:
URL: https://github.com/apache/spark/pull/34172#issuecomment-933837143


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48332/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34172: [SPARK-36874][SQL] DeduplicateRelations should copy dataset_id tag to avoid ambiguous self join

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34172:
URL: https://github.com/apache/spark/pull/34172#issuecomment-933939497


   **[Test build #143819 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143819/testReport)** for PR 34172 at commit [`d7c1f65`](https://github.com/apache/spark/commit/d7c1f657e78a61a95333687d7b76fc392b6281e0).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34172: [SPARK-36874][SQL] DeduplicateRelations should copy dataset_id tag to avoid ambiguous self join

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34172:
URL: https://github.com/apache/spark/pull/34172#issuecomment-933940628


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143819/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan closed pull request #34172: [SPARK-36874][SQL] DeduplicateRelations should copy dataset_id tag to avoid ambiguous self join

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #34172:
URL: https://github.com/apache/spark/pull/34172


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34172: [SPARK-36874][SQL] DeduplicateRelations should copy dataset_id tag to avoid ambiguous self join

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34172:
URL: https://github.com/apache/spark/pull/34172#issuecomment-933834519


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48332/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #34172: [SPARK-36874][SQL] DeduplicateRelations should copy dataset_id tag to avoid ambiguous self join

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34172:
URL: https://github.com/apache/spark/pull/34172#issuecomment-937389544


   @dongjoon-hyun Thank you for letting me know. It seems better to backport. I'll do it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34172: [SPARK-36874][SQL] DeduplicateRelations should copy dataset_id tag to avoid ambiguous self join

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34172:
URL: https://github.com/apache/spark/pull/34172#issuecomment-933764879


   **[Test build #143819 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143819/testReport)** for PR 34172 at commit [`d7c1f65`](https://github.com/apache/spark/commit/d7c1f657e78a61a95333687d7b76fc392b6281e0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34172: [SPARK-36874][SQL] DeduplicateRelations should copy dataset_id tag to avoid ambiguous self join

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34172:
URL: https://github.com/apache/spark/pull/34172#issuecomment-933764879


   **[Test build #143819 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143819/testReport)** for PR 34172 at commit [`d7c1f65`](https://github.com/apache/spark/commit/d7c1f657e78a61a95333687d7b76fc392b6281e0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org