You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/09/22 18:56:01 UTC
[kudu-CR] [c++client/samples] added README for the sample
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4517
Change subject: [c++client/samples] added README for the sample
......................................................................
[c++client/samples] added README for the sample
Added README in AsciiDoctor format describing how to build the sample.
Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
---
A src/kudu/client/samples/README.adoc
1 file changed, 103 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/4517/1
--
To view, visit http://gerrit.cloudera.org:8080/4517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [c++client/samples] added README for the sample
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4517
to look at the new patch set (#4).
Change subject: [c++client/samples] added README for the sample
......................................................................
[c++client/samples] added README for the sample
Added README in AsciiDoctor format describing how to build the sample.
Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
---
A src/kudu/client/samples/README.adoc
1 file changed, 89 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/4517/4
--
To view, visit http://gerrit.cloudera.org:8080/4517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [c++client/samples] added README for the sample
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [c++client/samples] added README for the sample
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [c++client/samples] added README for the sample
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4517
to look at the new patch set (#5).
Change subject: [c++client/samples] added README for the sample
......................................................................
[c++client/samples] added README for the sample
Added README in AsciiDoctor format describing how to build the sample.
Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
---
A src/kudu/client/samples/README.adoc
1 file changed, 89 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/4517/5
--
To view, visit http://gerrit.cloudera.org:8080/4517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [c++client/samples] added README for the sample
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4517
to look at the new patch set (#2).
Change subject: [c++client/samples] added README for the sample
......................................................................
[c++client/samples] added README for the sample
Added README in AsciiDoctor format describing how to build the sample.
Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
---
A src/kudu/client/samples/README.adoc
1 file changed, 109 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/4517/2
--
To view, visit http://gerrit.cloudera.org:8080/4517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [c++client/samples] added README for the sample
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4517
to look at the new patch set (#6).
Change subject: [c++client/samples] added README for the sample
......................................................................
[c++client/samples] added README for the sample
Added README in AsciiDoctor format describing how to build the sample.
Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
---
A src/kudu/client/samples/README.adoc
1 file changed, 167 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/4517/6
--
To view, visit http://gerrit.cloudera.org:8080/4517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [c++client/samples] added README for the sample
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [c++client/samples] added README for the sample
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4517/3/src/kudu/client/samples/README.adoc
File src/kudu/client/samples/README.adoc:
The rendered version is available at:
https://gist.github.com/alexeyserbin/bbf561d5753466d086383061fba0e0fd
--
To view, visit http://gerrit.cloudera.org:8080/4517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [c++client/samples] added README for the sample
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4517
to look at the new patch set (#3).
Change subject: [c++client/samples] added README for the sample
......................................................................
[c++client/samples] added README for the sample
Added README in AsciiDoctor format describing how to build the sample.
Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
---
A src/kudu/client/samples/README.adoc
1 file changed, 91 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/4517/3
--
To view, visit http://gerrit.cloudera.org:8080/4517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [c++client/samples] added README for the sample
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: [c++client/samples] added README for the sample
......................................................................
Patch Set 3:
(23 comments)
Some style, wording, and grammar nits. Don't have the chance to test out the instructions atm.
http://gerrit.cloudera.org:8080/#/c/4517/3/src/kudu/client/samples/README.adoc
File src/kudu/client/samples/README.adoc:
PS3, Line 6: of
remove extra "of"
PS3, Line 7:
add "the"
PS3, Line 7: demonstates
nit: missing r "demonstrates"
PS3, Line 7: which
nit: s/which/that/
PS3, Line 9:
add "the"
PS3, Line 16: at Kudu's Web site
"on Kudu's website" or "on the Kudu website"
PS3, Line 17: at
I like "on" best here, but "for" or "in" work. "at" doesn't sound right to me.
PS3, Line 17: `kudu-client0`
"`kudu-client0`package" or something to identify what it is
PS3, Line 25:
add "a"
PS3, Line 27: is also possible but it is not recommended
style nit: "is possible but is not recommended"
PS3, Line 28: level of
style nit: remove
PS3, Line 30: E.g.
nit: say "For example" when starting a sentence instead of e.g.
PS3, Line 39: Unpack the `sample.cc.gz` file:
I would just combine this step with the previous one, to make a single "navigate to the directory and unpack" step
PS3, Line 44: just use `debug` for `CMAKE_BUILD_TYPE` correspondingly
style nit: "use `debug` in place of `release` in the command below"
PS3, Line 59:
add "one" or "you"-- I think "you" is more in keeping with the rest of the doc
PS3, Line 63: if building
s/if building/to build/
PS3, Line 65: the directory
nit: remove
PS3, Line 68: E.g.
style nit: as above, s/E.g./For example/
PS3, Line 68:
add "an"
PS3, Line 75: E.g.
Same nit as above
PS3, Line 80: just use `debug` for `CMAKE_BUILD_TYPE` correspondingly
style nit: "use `debug` in place of `release` in the command below"
PS3, Line 85: and
extra "and"
Line 88:
Could you add a sample invocation and indicate what the user should see if the sample runs successfully?
--
To view, visit http://gerrit.cloudera.org:8080/4517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [c++client/samples] added README for the sample
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [c++client/samples] added README for the sample
......................................................................
[c++client/samples] added README for the sample
Added README in AsciiDoctor format describing how to build the sample.
Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Reviewed-on: http://gerrit.cloudera.org:8080/4517
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
A src/kudu/client/samples/README.adoc
1 file changed, 167 insertions(+), 0 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [c++client/samples] added README for the sample
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [c++client/samples] added README for the sample
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4517/1/src/kudu/client/samples/README.adoc
File src/kudu/client/samples/README.adoc:
Line 23: * Make sure `cmake` of version at least 2.6.2 is installed on the system.
> does the sample require this new of a cmake? in the past we actually built
Requiring cmake of 2.6.2 might be too lose here: it's a typo and the CMakeLists.txt itself declares mininum 2.8 :)
Will fix, thanks.
PS1, Line 31: /tmp/client_alt_root`
> doesn't seem to match what's used below
oops, this is due to too many revisions :)
Will fix.
PS1, Line 37: Change the d
> Change into the directory? cd into?
Done
Line 47: cmake -G "Unix Makefiles" -DkuduClient_DIR=/usr/local/share/kuduClient/cmake -DCMAKE_BUILD_TYPE=release
> the 'unix makefiles' is the default.
yep, that's the default. Probably, I added it here because I ran it with Xcode and Ninja. Will remove.
Without kuduClient_DIR it did not work for me if installing into alternative destroot. I just copied it over here as well. Will test and update for the default install root.
--
To view, visit http://gerrit.cloudera.org:8080/4517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [c++client/samples] added README for the sample
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [c++client/samples] added README for the sample
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4517/1/src/kudu/client/samples/README.adoc
File src/kudu/client/samples/README.adoc:
Line 47: cmake -G "Unix Makefiles" -DkuduClient_DIR=/usr/local/share/kuduClient/cmake -DCMAKE_BUILD_TYPE=release
> yep, that's the default. Probably, I added it here because I ran it with
As it turned out, cmake 2.8.12 on Ubuntu (trusty) and cmake 3.6.1 on MacOS X require -G option to run.
--
To view, visit http://gerrit.cloudera.org:8080/4517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [c++client/samples] added README for the sample
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [c++client/samples] added README for the sample
......................................................................
Patch Set 3:
(23 comments)
http://gerrit.cloudera.org:8080/#/c/4517/3/src/kudu/client/samples/README.adoc
File src/kudu/client/samples/README.adoc:
PS3, Line 6: of
> remove extra "of"
Done
PS3, Line 7: demonstates
> nit: missing r "demonstrates"
Done
PS3, Line 7: which
> nit: s/which/that/
Done
PS3, Line 7:
> add "the"
Done
PS3, Line 9:
> add "the"
Done
PS3, Line 16: at Kudu's Web site
> "on Kudu's website" or "on the Kudu website"
Done
PS3, Line 17: at
> I like "on" best here, but "for" or "in" work. "at" doesn't sound right to
Done
PS3, Line 17: `kudu-client0`
> "`kudu-client0`package" or something to identify what it is
Done
PS3, Line 25:
> add "a"
Done
PS3, Line 27: is also possible but it is not recommended
> style nit: "is possible but is not recommended"
Done
PS3, Line 28: level of
> style nit: remove
Done
PS3, Line 30: E.g.
> nit: say "For example" when starting a sentence instead of e.g.
Done
PS3, Line 39: Unpack the `sample.cc.gz` file:
> I would just combine this step with the previous one, to make a single "nav
Done
PS3, Line 44: just use `debug` for `CMAKE_BUILD_TYPE` correspondingly
> style nit: "use `debug` in place of `release` in the command below"
Done
PS3, Line 59:
> add "one" or "you"-- I think "you" is more in keeping with the rest of the
Done
PS3, Line 63: if building
> s/if building/to build/
Done
PS3, Line 65: the directory
> nit: remove
Done
PS3, Line 68:
> add "an"
Done
PS3, Line 68: E.g.
> style nit: as above, s/E.g./For example/
Done
PS3, Line 75: E.g.
> Same nit as above
Done
PS3, Line 80: just use `debug` for `CMAKE_BUILD_TYPE` correspondingly
> style nit: "use `debug` in place of `release` in the command below"
Done
PS3, Line 85: and
> extra "and"
Done
Line 88:
> Could you add a sample invocation and indicate what the user should see if
Done
--
To view, visit http://gerrit.cloudera.org:8080/4517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [c++client/samples] added README for the sample
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [c++client/samples] added README for the sample
......................................................................
Patch Set 1: Verified+1
The build failure is not relevant to this patch.
--
To view, visit http://gerrit.cloudera.org:8080/4517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [c++client/samples] added README for the sample
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [c++client/samples] added README for the sample
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4517/1/src/kudu/client/samples/README.adoc
File src/kudu/client/samples/README.adoc:
Line 23: * Make sure `cmake` of version at least 2.6.2 is installed on the system.
does the sample require this new of a cmake? in the past we actually built the sample using the system cmake rather than the thirdparty one.
PS1, Line 31: /tmp/client_alt_root`
doesn't seem to match what's used below
PS1, Line 37: Change the d
Change into the directory? cd into?
Line 47: cmake -G "Unix Makefiles" -DkuduClient_DIR=/usr/local/share/kuduClient/cmake -DCMAKE_BUILD_TYPE=release
the 'unix makefiles' is the default.
Also, does it not pick up the client from the system cmake stuff automatically? For some reason I thought it did.
--
To view, visit http://gerrit.cloudera.org:8080/4517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d75340b2690663b56082de590cf19ea315da4fe
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes