You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2015/07/30 16:55:04 UTC
[jira] [Commented] (LUCENE-6704) GeoPointInBBox/Distance queries
can throw OOME
[ https://issues.apache.org/jira/browse/LUCENE-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647739#comment-14647739 ]
Michael McCandless commented on LUCENE-6704:
--------------------------------------------
I'm a little lost on this issue. It's focusing on fixing the OOME? But the patch seems to do much more (good things!).
Can you add a dedicated standalone test that today hits OOME and then with this patch doesn't? To confirm the patch is fixing OOMEs in both GeoPointInBBoxQuery and GeoPointDistanceQuery...
Why is GeoPointDistanceQuery not final anymore? Seems like nothing wants to extend it...
I like the added javadocs, and BigInteger usage is always fun :)
> GeoPointInBBox/Distance queries can throw OOME
> ----------------------------------------------
>
> Key: LUCENE-6704
> URL: https://issues.apache.org/jira/browse/LUCENE-6704
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Nicholas Knize
> Attachments: LUCENE-6704.patch
>
>
> After investigating LUCENE-6685 the performance issues and improvements related to GeoPointInBBox/Distance queries could be categorized into two separate issues:
>
> 1. OOME caused by an unnecessary number of ranges computed for Point Distance Queries (bug in the GeoPointTermEnum base class where the bounding box was used for intersections instead of the point radius)
> 2. API improvements providing configurable detail parameters.
> This issue addresses 1. LUCENE-6685 will further investigate the need for 2 (after working 1 and correcting for unnecessary range detail, it looks like 2 may not be needed)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org