You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/07/07 20:34:09 UTC
Review Request 23316: Documentation for task health checking and graceful
shutdown.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23316/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Bugs: AURORA-574
https://issues.apache.org/jira/browse/AURORA-574
Repository: aurora
Description
-------
One issue i noticed was anchor tags not working consistently. Apparently github prefixes anchors with "user-content-", which might be related to some anchors not working despite matching the convention used elsewhere. Others have noted this: https://github.com/joeyespo/grip/issues/58
Diffs
-----
docs/user-guide.md 583a41f8e3eee172a76370e3040eb5ac7d350990
Diff: https://reviews.apache.org/r/23316/diff/
Testing
-------
Pushed to a branch on github: https://github.com/wfarner/incubator-aurora/blob/wfarner/health_check_doc/docs/user-guide.md#user-content-http-health-checking-and-graceful-shutdown
Thanks,
Bill Farner
Re: Review Request 23316: Documentation for task health checking and
graceful shutdown.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23316/#review48069
-----------------------------------------------------------
Kevin - ping?
- Bill Farner
On July 7, 2014, 6:34 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23316/
> -----------------------------------------------------------
>
> (Updated July 7, 2014, 6:34 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-574
> https://issues.apache.org/jira/browse/AURORA-574
>
>
> Repository: aurora
>
>
> Description
> -------
>
> One issue i noticed was anchor tags not working consistently. Apparently github prefixes anchors with "user-content-", which might be related to some anchors not working despite matching the convention used elsewhere. Others have noted this: https://github.com/joeyespo/grip/issues/58
>
>
> Diffs
> -----
>
> docs/user-guide.md 583a41f8e3eee172a76370e3040eb5ac7d350990
>
> Diff: https://reviews.apache.org/r/23316/diff/
>
>
> Testing
> -------
>
> Pushed to a branch on github: https://github.com/wfarner/incubator-aurora/blob/wfarner/health_check_doc/docs/user-guide.md#user-content-http-health-checking-and-graceful-shutdown
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 23316: Documentation for task health checking and
graceful shutdown.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23316/#review48446
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On July 7, 2014, 11:34 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23316/
> -----------------------------------------------------------
>
> (Updated July 7, 2014, 11:34 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-574
> https://issues.apache.org/jira/browse/AURORA-574
>
>
> Repository: aurora
>
>
> Description
> -------
>
> One issue i noticed was anchor tags not working consistently. Apparently github prefixes anchors with "user-content-", which might be related to some anchors not working despite matching the convention used elsewhere. Others have noted this: https://github.com/joeyespo/grip/issues/58
>
>
> Diffs
> -----
>
> docs/user-guide.md 583a41f8e3eee172a76370e3040eb5ac7d350990
>
> Diff: https://reviews.apache.org/r/23316/diff/
>
>
> Testing
> -------
>
> Pushed to a branch on github: https://github.com/wfarner/incubator-aurora/blob/wfarner/health_check_doc/docs/user-guide.md#user-content-http-health-checking-and-graceful-shutdown
>
>
> Thanks,
>
> Bill Farner
>
>