[GitHub] [arrow-datafusion] viirya commented on a diff in pull request #7048: Initial Support of Decimal256 ScalarValue

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #7048:
URL: https://github.com/apache/arrow-datafusion/pull/7048#discussion_r1269990005


##########
datafusion/common/src/scalar.rs:
##########
@@ -1038,6 +1054,7 @@ macro_rules! impl_op_arithmetic {
                 get_sign!($OPERATION),
                 true,
             )))),
+            // todo: Add Decimal256 support

Review Comment:
   The error of running
   
   ```
   create table t as values (arrow_cast(123, 'Decimal256(5,2)'));
   select AVG(column1) from t;
   ```
   
   in decimal.slt comes from lack of implementation of Decimal256 Scalar arithmetic op.
   
   It seems to be not easy to finish right now. So I left it as todo here.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org