[GitHub] [hadoop] steveloughran commented on a diff in pull request #6057: HADOOP-18890: remove use of okhttp in runtime code

["steveloughran (via GitHub)" <gi...@apache.org>]

steveloughran commented on code in PR #6057:
URL: https://github.com/apache/hadoop/pull/6057#discussion_r1327358545


##########
hadoop-project/pom.xml:
##########
@@ -220,62 +218,6 @@
 
   <dependencyManagement>
     <dependencies>
-      <dependency>

Review Comment:
   this should be reinstated with the new exclusions; then the test declarations don't need changing. 



##########
hadoop-common-project/hadoop-common/pom.xml:
##########
@@ -391,11 +391,19 @@
     <dependency>
       <groupId>com.squareup.okhttp3</groupId>
       <artifactId>mockwebserver</artifactId>
+      <version>${okhttp3.version}</version>

Review Comment:
   prefer hadoop-project retains the declaration, but now with all the excludes. the modules should get the exclusions automatically, shouldn't they?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org