You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2024/03/27 20:28:11 UTC
Re: [PR] [GOBBLIN-2027] move DagActionStore from gobblin-runtime to gobblin-service [gobblin]
codecov-commenter commented on PR #3904:
URL: https://github.com/apache/gobblin/pull/3904#issuecomment-2023917694
## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3904?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `44.73684%` with `21 lines` in your changes are missing coverage. Please review.
> Project coverage is 46.60%. Comparing base [(`de50eaf`)](https://app.codecov.io/gh/apache/gobblin/commit/de50eaf54e496a01e8a0759d942572d1359b5f98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6d10ac4`)](https://app.codecov.io/gh/apache/gobblin/pull/3904?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files](https://app.codecov.io/gh/apache/gobblin/pull/3904?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...vice/modules/orchestration/LeaseAttemptStatus.java](https://app.codecov.io/gh/apache/gobblin/pull/3904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0xlYXNlQXR0ZW1wdFN0YXR1cy5qYXZh) | 50.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/gobblin/pull/3904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rvice/modules/orchestration/FlowLaunchHandler.java](https://app.codecov.io/gh/apache/gobblin/pull/3904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0Zsb3dMYXVuY2hIYW5kbGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/gobblin/pull/3904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...odules/orchestration/InstrumentedLeaseArbiter.java](https://app.codecov.io/gh/apache/gobblin/pull/3904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0luc3RydW1lbnRlZExlYXNlQXJiaXRlci5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/gobblin/pull/3904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../service/modules/orchestration/DagActionStore.java](https://app.codecov.io/gh/apache/gobblin/pull/3904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ0FjdGlvblN0b3JlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/gobblin/pull/3904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hestration/ReminderSettingDagProcLeaseArbiter.java](https://app.codecov.io/gh/apache/gobblin/pull/3904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL1JlbWluZGVyU2V0dGluZ0RhZ1Byb2NMZWFzZUFyYml0ZXIuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/gobblin/pull/3904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...es/orchestration/MysqlMultiActiveLeaseArbiter.java](https://app.codecov.io/gh/apache/gobblin/pull/3904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL015c3FsTXVsdGlBY3RpdmVMZWFzZUFyYml0ZXIuamF2YQ==) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/gobblin/pull/3904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3904 +/- ##
============================================
- Coverage 46.61% 46.60% -0.02%
- Complexity 11219 11221 +2
============================================
Files 2241 2241
Lines 88342 88344 +2
Branches 9673 9673
============================================
- Hits 41184 41172 -12
- Misses 43447 43464 +17
+ Partials 3711 3708 -3
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3904?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org