You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@baremaps.apache.org by "YongGoose (via GitHub)" <gi...@apache.org> on 2025/02/02 07:30:26 UTC

[PR] Display building numbers [incubator-baremaps]

YongGoose opened a new pull request, #945:
URL: https://github.com/apache/incubator-baremaps/pull/945

   Resolves #931 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Display building numbers [incubator-baremaps]

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on PR #945:
URL: https://github.com/apache/incubator-baremaps/pull/945#issuecomment-2629333994

   I think it is mainly a matter of reordering the layers in the main style file. Do not hesitate to play with the order and put legends on top if necessary.
   
   https://github.com/apache/incubator-baremaps/blob/0f05dead22d7906e2453a6a4cb585a41bac62774/basemap/style.js#L83


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Display building numbers [incubator-baremaps]

Posted by "YongGoose (via GitHub)" <gi...@apache.org>.
YongGoose commented on PR #945:
URL: https://github.com/apache/incubator-baremaps/pull/945#issuecomment-2629343390

   > I think it is mainly a matter of reordering the layers in the main style file. Do not hesitate to play with the order and put legends on top if necessary.
   
   Thank you so much.  
   
   Adjusting the layer order solved the issue.  
   From now on, I won’t hesitate to experiment with the order freely.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Display building numbers [incubator-baremaps]

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on PR #945:
URL: https://github.com/apache/incubator-baremaps/pull/945#issuecomment-2630393586

   Looks good to me 👍 thank you for the contribution. I will open another issue to move the steps in the text-size values for all labels (highways, buildings, etc.) in the `default.js` theme.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Display building numbers [incubator-baremaps]

Posted by "YongGoose (via GitHub)" <gi...@apache.org>.
YongGoose commented on PR #945:
URL: https://github.com/apache/incubator-baremaps/pull/945#issuecomment-2629281372

   @bchapuis 
   
   Due to this issue, I prioritized working on #931 
   
   While working on it, I encountered something that needs to be resolved. 
   I was able to successfully print the building number, but the problem is that the **building number is positioned behind the building.** 
   
   ![image](https://github.com/user-attachments/assets/f11fc1ca-6594-4a55-b6ce-0e64b6602cf3)
   
   I tried applying the `addLayer` from maplibre, but the building number still appears beneath the building.
   - https://maplibre.org/maplibre-gl-js/docs/examples/geojson-layer-in-stack/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Display building numbers [incubator-baremaps]

Posted by "YongGoose (via GitHub)" <gi...@apache.org>.
YongGoose commented on PR #945:
URL: https://github.com/apache/incubator-baremaps/pull/945#issuecomment-2629345046

   Could you please check the **building number** size?
   
   Additionally, when there are multiple numbers for a single building, the numbers don’t appear. 
   What do you think about this?
   
   ### OpenStreetMap
   ![image](https://github.com/user-attachments/assets/32a11d84-3e5e-443a-99d4-890038c4f58d)
   
   ### baremaps
   ![image](https://github.com/user-attachments/assets/b85e237e-f4a5-4001-b3e2-e11fa52840c4)
   
   I checked the `tags` of `osm_building` in the database, and it seems that the building number is missing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Display building numbers [incubator-baremaps]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #945:
URL: https://github.com/apache/incubator-baremaps/pull/945#issuecomment-2629342978

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=945) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=945&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=945&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=945&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=945&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=945&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=945)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Display building numbers [incubator-baremaps]

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis merged PR #945:
URL: https://github.com/apache/incubator-baremaps/pull/945


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Display building numbers [incubator-baremaps]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #945:
URL: https://github.com/apache/incubator-baremaps/pull/945#issuecomment-2629280644

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=945) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=945&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_baremaps&pullRequest=945&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_baremaps&pullRequest=945&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=945&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_baremaps&pullRequest=945&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_baremaps&pullRequest=945)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org