You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by ap...@apache.org on 2007/05/04 15:38:03 UTC
svn commit: r535236 - in
/harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound:
midi/MidiSystem.java sampled/AudioFormat.java sampled/Control.java
sampled/LineEvent.java
Author: apetrenko
Date: Fri May 4 06:38:01 2007
New Revision: 535236
URL: http://svn.apache.org/viewvc?view=rev&rev=535236
Log:
Patch for HARMONY-3813 "[classlib][sound] japitool reports errors for sound module"
Modified:
harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/midi/MidiSystem.java
harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/sampled/AudioFormat.java
harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/sampled/Control.java
harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/sampled/LineEvent.java
Modified: harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/midi/MidiSystem.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/midi/MidiSystem.java?view=diff&rev=535236&r1=535235&r2=535236
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/midi/MidiSystem.java (original)
+++ harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/midi/MidiSystem.java Fri May 4 06:38:01 2007
@@ -35,6 +35,10 @@
import org.apache.harmony.sound.utils.ProviderService;
public class MidiSystem {
+ // This class has no public constructor
+ private MidiSystem() {
+ }
+
//path to javax.sound.midi.spi.MidiDeviceProvider file in the jar-file
private final static String midiDeviceProviderPath =
"META-INF/services/javax.sound.midi.spi.MidiDeviceProvider";
Modified: harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/sampled/AudioFormat.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/sampled/AudioFormat.java?view=diff&rev=535236&r1=535235&r2=535236
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/sampled/AudioFormat.java (original)
+++ harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/sampled/AudioFormat.java Fri May 4 06:38:01 2007
@@ -39,7 +39,7 @@
}
@Override
- public boolean equals(Object another) {
+ public final boolean equals(Object another) {
if (this == another) {
return true;
}
Modified: harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/sampled/Control.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/sampled/Control.java?view=diff&rev=535236&r1=535235&r2=535236
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/sampled/Control.java (original)
+++ harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/sampled/Control.java Fri May 4 06:38:01 2007
@@ -23,12 +23,12 @@
private String name;
- public Type(String name) {
+ protected Type(String name) {
this.name = name;
}
@Override
- public boolean equals(Object another) {
+ public final boolean equals(Object another) {
if (this == another) {
return true;
}
Modified: harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/sampled/LineEvent.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/sampled/LineEvent.java?view=diff&rev=535236&r1=535235&r2=535236
==============================================================================
--- harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/sampled/LineEvent.java (original)
+++ harmony/enhanced/classlib/trunk/modules/sound/src/main/java/javax/sound/sampled/LineEvent.java Fri May 4 06:38:01 2007
@@ -41,12 +41,12 @@
private String name;
- public Type(String name) {
+ protected Type(String name) {
this.name = name;
}
@Override
- public boolean equals(Object another) {
+ public final boolean equals(Object another) {
if (this == another) {
return true;
}