You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/01/15 00:46:44 UTC
[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #19755: Onnx nms
Zha0q1 opened a new pull request #19755:
URL: https://github.com/apache/incubator-mxnet/pull/19755
box nms op
currently does not support `id_index` and `background_id` -- we can add those later if requested
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 merged pull request #19755: [v1.x] ONNX contrib_box_nms
Posted by GitBox <gi...@apache.org>.
Zha0q1 merged pull request #19755:
URL: https://github.com/apache/incubator-mxnet/pull/19755
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19755: [wip][v1.x] ONNX contrib_box_nms
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19755:
URL: https://github.com/apache/incubator-mxnet/pull/19755#issuecomment-761290435
@josephevans thanks for reviewing, will change. Additionally I need to fix the graph linking issue when a node have > 1 output, thus adding [wip]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19755: Onnx nms
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19755:
URL: https://github.com/apache/incubator-mxnet/pull/19755#issuecomment-760570279
Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [edge, clang, miscellaneous, windows-cpu, windows-gpu, website, centos-cpu, unix-gpu, unix-cpu, sanity, centos-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #19755: [v1.x] ONNX contrib_box_nms
Posted by GitBox <gi...@apache.org>.
josephevans commented on a change in pull request #19755:
URL: https://github.com/apache/incubator-mxnet/pull/19755#discussion_r558743783
##########
File path: python/mxnet/contrib/onnx/mx2onnx/export_onnx.py
##########
@@ -140,8 +141,10 @@ def get_outputs(sym, params, in_shape, in_label, in_type):
out_names = list()
for name in sym.list_outputs():
- if name.endswith('_output'):
+ if re.search('.*_output$', name):
Review comment:
Why use a regex here? endswith would be more efficient.
##########
File path: python/mxnet/contrib/onnx/mx2onnx/export_onnx.py
##########
@@ -140,8 +141,10 @@ def get_outputs(sym, params, in_shape, in_label, in_type):
out_names = list()
for name in sym.list_outputs():
- if name.endswith('_output'):
+ if re.search('.*_output$', name):
out_names.append(name[:-len('_output')])
+ elif re.search('.*_output[0-9]$', name):
Review comment:
Instead of using a regex here, you could just check for output in the string, like:
if name[-len('output0'):-1] == 'output':
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org