You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "js8544 (via GitHub)" <gi...@apache.org> on 2023/12/09 16:14:12 UTC
[PR] GH-39156: [Compute] Fix negative duration division [arrow]
js8544 opened a new pull request, #39158:
URL: https://github.com/apache/arrow/pull/39158
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
I forgot to cast durations to doubles in the current `division(duration, duration)` kernel. So they were essentially `reinterpret_cast`ed to double. Because I only tested small positive ints but not large ints or negative ints, I missed this bug.
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Add a `FloatingDivide` operator that casts ints to doubles and do floating division. Replace the `division(duration, duration)` with this op.
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
Yes.
### Are there any user-facing changes?
No.
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39156: [C++][Compute] Fix negative duration division [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #39158:
URL: https://github.com/apache/arrow/pull/39158#discussion_r1421561642
##########
cpp/src/arrow/compute/kernels/base_arithmetic_internal.h:
##########
@@ -426,6 +426,45 @@ struct DivideChecked {
}
};
+struct FloatingDivide {
+ template <typename T, typename Arg0, typename Arg1>
+ static enable_if_floating_value<Arg0> Call(KernelContext*, Arg0 left, Arg1 right,
+ Status*) {
+ return left / right;
+ }
+
+ template <typename T, typename Arg0, typename Arg1>
+ static enable_if_integer_value<Arg0, double> Call(KernelContext* ctx, Arg0 left,
+ Arg1 right, Status* st) {
+ static_assert(std::is_same<Arg0, Arg1>::value);
+ return Call<double>(ctx, static_cast<double>(left), static_cast<double>(right), st);
+ }
+
+ // TODO: Add decimal
+};
+
+struct FloatingDivideChecked {
+ template <typename T, typename Arg0, typename Arg1>
+ static enable_if_integer_value<Arg0, double> Call(KernelContext* ctx, Arg0 left,
+ Arg1 right, Status* st) {
+ static_assert(std::is_same<Arg0, Arg1>::value);
+ return Call<double>(ctx, static_cast<double>(left), static_cast<double>(right), st);
+ }
+
+ template <typename T, typename Arg0, typename Arg1>
+ static enable_if_floating_value<Arg0> Call(KernelContext*, Arg0 left, Arg1 right,
+ Status* st) {
+ static_assert(std::is_same<T, Arg0>::value && std::is_same<T, Arg1>::value);
+ if (ARROW_PREDICT_FALSE(right == 0)) {
+ *st = Status::Invalid("divide by zero");
+ return 0;
+ }
+ return left / right;
+ }
Review Comment:
How about using the same order as `FloatingDivide` for easy to read?
(`enable_if_floating_value` -> `enable_if_integer_value` order.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39156: [C++][Compute] Fix negative duration division [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #39158:
URL: https://github.com/apache/arrow/pull/39158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39156: [Compute] Fix negative duration division [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39158:
URL: https://github.com/apache/arrow/pull/39158#issuecomment-1848451914
:warning: GitHub issue #39156 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39156: [C++][Compute] Fix negative duration division [arrow]
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on code in PR #39158:
URL: https://github.com/apache/arrow/pull/39158#discussion_r1421616243
##########
cpp/src/arrow/compute/kernels/base_arithmetic_internal.h:
##########
@@ -426,6 +426,45 @@ struct DivideChecked {
}
};
+struct FloatingDivide {
+ template <typename T, typename Arg0, typename Arg1>
+ static enable_if_floating_value<Arg0> Call(KernelContext*, Arg0 left, Arg1 right,
+ Status*) {
+ return left / right;
+ }
+
+ template <typename T, typename Arg0, typename Arg1>
+ static enable_if_integer_value<Arg0, double> Call(KernelContext* ctx, Arg0 left,
+ Arg1 right, Status* st) {
+ static_assert(std::is_same<Arg0, Arg1>::value);
+ return Call<double>(ctx, static_cast<double>(left), static_cast<double>(right), st);
+ }
+
+ // TODO: Add decimal
+};
+
+struct FloatingDivideChecked {
+ template <typename T, typename Arg0, typename Arg1>
+ static enable_if_integer_value<Arg0, double> Call(KernelContext* ctx, Arg0 left,
+ Arg1 right, Status* st) {
+ static_assert(std::is_same<Arg0, Arg1>::value);
+ return Call<double>(ctx, static_cast<double>(left), static_cast<double>(right), st);
+ }
+
+ template <typename T, typename Arg0, typename Arg1>
+ static enable_if_floating_value<Arg0> Call(KernelContext*, Arg0 left, Arg1 right,
+ Status* st) {
+ static_assert(std::is_same<T, Arg0>::value && std::is_same<T, Arg1>::value);
+ if (ARROW_PREDICT_FALSE(right == 0)) {
+ *st = Status::Invalid("divide by zero");
+ return 0;
+ }
+ return left / right;
+ }
Review Comment:
Sure! Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39156: [Compute] Fix negative duration division [arrow]
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #39158:
URL: https://github.com/apache/arrow/pull/39158#issuecomment-1848599010
> Does this fix #38566 as well?
Yes! It should. Sorry for missing your issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39156: [Compute] Fix negative duration division [arrow]
Posted by "rohanjain101 (via GitHub)" <gi...@apache.org>.
rohanjain101 commented on PR #39158:
URL: https://github.com/apache/arrow/pull/39158#issuecomment-1848597807
Does this fix https://github.com/apache/arrow/issues/38566 as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39156: [C++][Compute] Fix negative duration division [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39158:
URL: https://github.com/apache/arrow/pull/39158#issuecomment-1849070894
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit cca5eec5fd853d4593dfe1b6c158e9543d32619f.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/19494022998) has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org