[GitHub] [rocketmq] Oliverwqcwrw commented on a diff in pull request #4573: [ISSUE #4559] Remove unnecessary operation of logicsMsgTimestamp

[GitBox <gi...@apache.org>]

Oliverwqcwrw commented on code in PR #4573:
URL: https://github.com/apache/rocketmq/pull/4573#discussion_r923101814


##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -1552,26 +1552,28 @@ public void run2() {
             }
         }, 1, 10, TimeUnit.MINUTES);
 
-        this.scheduledExecutorService.scheduleAtFixedRate(new AbstractBrokerRunnable(this.getBrokerIdentity()) {
-            @Override
-            public void run2() {
-                if (DefaultMessageStore.this.getMessageStoreConfig().isDebugLockEnable()) {
+        if (DefaultMessageStore.this.getMessageStoreConfig().isDebugLockEnable()) {

Review Comment:
   I think this is  better  to put in the `run()`, can support the debugLockEnable dynamic modification, WDYT
   
   Please let me know if I am missing something



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org