You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Gregory Chanan (JIRA)" <ji...@apache.org> on 2012/05/03 23:50:50 UTC
[jira] [Created] (HBASE-5932) Move RegionServerStatusProtocol from
ipc package to top-level
Gregory Chanan created HBASE-5932:
-------------------------------------
Summary: Move RegionServerStatusProtocol from ipc package to top-level
Key: HBASE-5932
URL: https://issues.apache.org/jira/browse/HBASE-5932
Project: HBase
Issue Type: Task
Affects Versions: 0.96.0
Reporter: Gregory Chanan
Assignee: Gregory Chanan
Priority: Trivial
>From Stack's comment on HBASE-5444:
We can move the ipc protocol stuff to top level later... I was thinking that these classes shared by master and regionservers could be at o.a.h.h... but can do that later if it makes sense. Lets get this pb stuff in first.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5932) Move RegionServerStatusProtocol
from ipc package to top-level
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286216#comment-13286216 ]
Hudson commented on HBASE-5932:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #33 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/33/])
HBASE-5932 Move RegionServerStatusProtocol from ipc package to top-level (Revision 1344432)
HBASE-5932 Move RegionServerStatusProtocol from ipc package to top-level (Revision 1344430)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/RegionServerStatusProtocol.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RegionServerStatusProtocol.java
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java
> Move RegionServerStatusProtocol from ipc package to top-level
> -------------------------------------------------------------
>
> Key: HBASE-5932
> URL: https://issues.apache.org/jira/browse/HBASE-5932
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.96.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-5932-v2.patch, HBASE-5932.patch
>
>
> From Stack's comment on HBASE-5444:
> We can move the ipc protocol stuff to top level later... I was thinking that these classes shared by master and regionservers could be at o.a.h.h... but can do that later if it makes sense. Lets get this pb stuff in first.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5932) Move RegionServerStatusProtocol from
ipc package to top-level
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-5932:
----------------------------------
Status: Patch Available (was: Open)
> Move RegionServerStatusProtocol from ipc package to top-level
> -------------------------------------------------------------
>
> Key: HBASE-5932
> URL: https://issues.apache.org/jira/browse/HBASE-5932
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.96.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Attachments: HBASE-5932.patch
>
>
> From Stack's comment on HBASE-5444:
> We can move the ipc protocol stuff to top level later... I was thinking that these classes shared by master and regionservers could be at o.a.h.h... but can do that later if it makes sense. Lets get this pb stuff in first.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5932) Move RegionServerStatusProtocol
from ipc package to top-level
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278349#comment-13278349 ]
Gregory Chanan commented on HBASE-5932:
---------------------------------------
Ran unit test locally and it passes.
> Move RegionServerStatusProtocol from ipc package to top-level
> -------------------------------------------------------------
>
> Key: HBASE-5932
> URL: https://issues.apache.org/jira/browse/HBASE-5932
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.96.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Attachments: HBASE-5932.patch
>
>
> From Stack's comment on HBASE-5444:
> We can move the ipc protocol stuff to top level later... I was thinking that these classes shared by master and regionservers could be at o.a.h.h... but can do that later if it makes sense. Lets get this pb stuff in first.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5932) Move RegionServerStatusProtocol from
ipc package to top-level
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-5932:
----------------------------------
Attachment: HBASE-5932-v2.patch
> Move RegionServerStatusProtocol from ipc package to top-level
> -------------------------------------------------------------
>
> Key: HBASE-5932
> URL: https://issues.apache.org/jira/browse/HBASE-5932
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.96.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Attachments: HBASE-5932-v2.patch, HBASE-5932.patch
>
>
> From Stack's comment on HBASE-5444:
> We can move the ipc protocol stuff to top level later... I was thinking that these classes shared by master and regionservers could be at o.a.h.h... but can do that later if it makes sense. Lets get this pb stuff in first.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5932) Move RegionServerStatusProtocol
from ipc package to top-level
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286032#comment-13286032 ]
Hudson commented on HBASE-5932:
-------------------------------
Integrated in HBase-TRUNK #2956 (See [https://builds.apache.org/job/HBase-TRUNK/2956/])
HBASE-5932 Move RegionServerStatusProtocol from ipc package to top-level (Revision 1344432)
HBASE-5932 Move RegionServerStatusProtocol from ipc package to top-level (Revision 1344430)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/RegionServerStatusProtocol.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RegionServerStatusProtocol.java
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java
> Move RegionServerStatusProtocol from ipc package to top-level
> -------------------------------------------------------------
>
> Key: HBASE-5932
> URL: https://issues.apache.org/jira/browse/HBASE-5932
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.96.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-5932-v2.patch, HBASE-5932.patch
>
>
> From Stack's comment on HBASE-5444:
> We can move the ipc protocol stuff to top level later... I was thinking that these classes shared by master and regionservers could be at o.a.h.h... but can do that later if it makes sense. Lets get this pb stuff in first.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5932) Move RegionServerStatusProtocol
from ipc package to top-level
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285308#comment-13285308 ]
Hadoop QA commented on HBASE-5932:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530124/HBASE-5932-v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2041//testReport/
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2041//console
This message is automatically generated.
> Move RegionServerStatusProtocol from ipc package to top-level
> -------------------------------------------------------------
>
> Key: HBASE-5932
> URL: https://issues.apache.org/jira/browse/HBASE-5932
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.96.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Attachments: HBASE-5932-v2.patch, HBASE-5932.patch
>
>
> From Stack's comment on HBASE-5444:
> We can move the ipc protocol stuff to top level later... I was thinking that these classes shared by master and regionservers could be at o.a.h.h... but can do that later if it makes sense. Lets get this pb stuff in first.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5932) Move RegionServerStatusProtocol
from ipc package to top-level
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278324#comment-13278324 ]
Hadoop QA commented on HBASE-5932:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12527925/HBASE-5932.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 32 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1919//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1919//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1919//console
This message is automatically generated.
> Move RegionServerStatusProtocol from ipc package to top-level
> -------------------------------------------------------------
>
> Key: HBASE-5932
> URL: https://issues.apache.org/jira/browse/HBASE-5932
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.96.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Attachments: HBASE-5932.patch
>
>
> From Stack's comment on HBASE-5444:
> We can move the ipc protocol stuff to top level later... I was thinking that these classes shared by master and regionservers could be at o.a.h.h... but can do that later if it makes sense. Lets get this pb stuff in first.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5932) Move RegionServerStatusProtocol from
ipc package to top-level
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-5932:
----------------------------------
Attachment: HBASE-5932.patch
Attach patch that moves from ipc package to top-level
> Move RegionServerStatusProtocol from ipc package to top-level
> -------------------------------------------------------------
>
> Key: HBASE-5932
> URL: https://issues.apache.org/jira/browse/HBASE-5932
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.96.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Attachments: HBASE-5932.patch
>
>
> From Stack's comment on HBASE-5444:
> We can move the ipc protocol stuff to top level later... I was thinking that these classes shared by master and regionservers could be at o.a.h.h... but can do that later if it makes sense. Lets get this pb stuff in first.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5932) Move RegionServerStatusProtocol from
ipc package to top-level
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5932:
-------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for the patch Gregory.
> Move RegionServerStatusProtocol from ipc package to top-level
> -------------------------------------------------------------
>
> Key: HBASE-5932
> URL: https://issues.apache.org/jira/browse/HBASE-5932
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.96.0
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-5932-v2.patch, HBASE-5932.patch
>
>
> From Stack's comment on HBASE-5444:
> We can move the ipc protocol stuff to top level later... I was thinking that these classes shared by master and regionservers could be at o.a.h.h... but can do that later if it makes sense. Lets get this pb stuff in first.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira