You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/06/23 23:48:15 UTC
[kudu-CR] [autn token expire-itest] make one scenario more robust
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16107
Change subject: [autn_token_expire-itest] make one scenario more robust
......................................................................
[autn_token_expire-itest] make one scenario more robust
This patch addresses a TICTOU condition in ClientReacquiresAuthnToken
scenario of the MultiMasterIdleConnectionsITest test and replaces ad-hoc
master re-election requests with graceful leadership transfer.
I haven't seen the TICTOU condition manifesting itself yet, but since
I already spent time on looking around to find the reason behind the
test failure (the root cause has been found and is fixed by
https://gerrit.cloudera.org/#/c/16106/), it doesn't hurt to make the
test scenario a bit more robust.
Change-Id: Id06be851c92958c2c134d9e06a7dc133283aeba2
---
M src/kudu/integration-tests/auth_token_expire-itest.cc
1 file changed, 23 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/16107/1
--
To view, visit http://gerrit.cloudera.org:8080/16107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id06be851c92958c2c134d9e06a7dc133283aeba2
Gerrit-Change-Number: 16107
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [autn token expire-itest] make one scenario more robust
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16107 )
Change subject: [autn_token_expire-itest] make one scenario more robust
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id06be851c92958c2c134d9e06a7dc133283aeba2
Gerrit-Change-Number: 16107
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 24 Jun 2020 02:28:43 +0000
Gerrit-HasComments: No
[kudu-CR] [autn token expire-itest] make one scenario more robust
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16107 )
Change subject: [autn_token_expire-itest] make one scenario more robust
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16107/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16107/1//COMMIT_MSG@9
PS1, Line 9: TICTOU
> nit: TOCTOU? same below
Done
--
To view, visit http://gerrit.cloudera.org:8080/16107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id06be851c92958c2c134d9e06a7dc133283aeba2
Gerrit-Change-Number: 16107
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 24 Jun 2020 02:27:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] [autn token expire-itest] make one scenario more robust
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Grant Henke, Greg Solovyev,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16107
to look at the new patch set (#2).
Change subject: [autn_token_expire-itest] make one scenario more robust
......................................................................
[autn_token_expire-itest] make one scenario more robust
This patch addresses a TOCTOU condition in ClientReacquiresAuthnToken
scenario of the MultiMasterIdleConnectionsITest test and replaces ad-hoc
master re-election requests with graceful leadership transfer.
I haven't seen the TOCTOU condition manifesting itself yet, but since
I already spent time on looking around to find the reason behind the
test failure (the root cause has been found and is fixed by
https://gerrit.cloudera.org/#/c/16106/), it doesn't hurt to make the
test scenario a bit more robust.
Change-Id: Id06be851c92958c2c134d9e06a7dc133283aeba2
---
M src/kudu/integration-tests/auth_token_expire-itest.cc
1 file changed, 23 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/16107/2
--
To view, visit http://gerrit.cloudera.org:8080/16107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id06be851c92958c2c134d9e06a7dc133283aeba2
Gerrit-Change-Number: 16107
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [autn token expire-itest] make one scenario more robust
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16107 )
Change subject: [autn_token_expire-itest] make one scenario more robust
......................................................................
Patch Set 2: Verified+1
Unrelated test failure in HmsConfigurations/MasterStressTest.Test/1 (ASAN)
--
To view, visit http://gerrit.cloudera.org:8080/16107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id06be851c92958c2c134d9e06a7dc133283aeba2
Gerrit-Change-Number: 16107
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 24 Jun 2020 04:20:01 +0000
Gerrit-HasComments: No
[kudu-CR] [autn token expire-itest] make one scenario more robust
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16107 )
Change subject: [autn_token_expire-itest] make one scenario more robust
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16107/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16107/1//COMMIT_MSG@9
PS1, Line 9: TICTOU
nit: TOCTOU? same below
--
To view, visit http://gerrit.cloudera.org:8080/16107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id06be851c92958c2c134d9e06a7dc133283aeba2
Gerrit-Change-Number: 16107
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 24 Jun 2020 01:46:51 +0000
Gerrit-HasComments: Yes
[kudu-CR] [autn token expire-itest] make one scenario more robust
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [autn_token_expire-itest] make one scenario more robust
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id06be851c92958c2c134d9e06a7dc133283aeba2
Gerrit-Change-Number: 16107
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [autn token expire-itest] make one scenario more robust
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16107 )
Change subject: [autn_token_expire-itest] make one scenario more robust
......................................................................
[autn_token_expire-itest] make one scenario more robust
This patch addresses a TOCTOU condition in ClientReacquiresAuthnToken
scenario of the MultiMasterIdleConnectionsITest test and replaces ad-hoc
master re-election requests with graceful leadership transfer.
I haven't seen the TOCTOU condition manifesting itself yet, but since
I already spent time on looking around to find the reason behind the
test failure (the root cause has been found and is fixed by
https://gerrit.cloudera.org/#/c/16106/), it doesn't hurt to make the
test scenario a bit more robust.
Change-Id: Id06be851c92958c2c134d9e06a7dc133283aeba2
Reviewed-on: http://gerrit.cloudera.org:8080/16107
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/auth_token_expire-itest.cc
1 file changed, 23 insertions(+), 14 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id06be851c92958c2c134d9e06a7dc133283aeba2
Gerrit-Change-Number: 16107
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)