[GitHub] [helix] narendly commented on a change in pull request #359: Dynamically change the processor thread name when consuming event

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #359: Dynamically change the processor thread name when consuming event
URL: https://github.com/apache/helix/pull/359#discussion_r309471472
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
 ##########
 @@ -1165,7 +1163,11 @@ public void run() {
               + _processorName);
       while (!isInterrupted()) {
         try {
-          handleEvent(_eventBlockingQueue.take(), _cache);
+          ClusterEvent newClusterEvent = _eventBlockingQueue.take();
 
 Review comment:
   Would it be better to add some helper methods within ClusterEvent that stores a "threadName", and modify by using a setter?
   
   This way, we save an object creation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services