You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2024/05/20 23:46:32 UTC
[PR] [SPARK-48363][SQL] Cleanup some redundant codes in `from_xml` [spark]
panbingkun opened a new pull request, #46674:
URL: https://github.com/apache/spark/pull/46674
### What changes were proposed in this pull request?
The PR aims to cleanup some redundant codes (support for `ArrayType` & `MapType`)
### Why are the changes needed?
As discussed below, we will not support `ArrayType` and `MapType` in `from_xml`, so we can re move the logic related to them.
https://issues.apache.org/jira/browse/SPARK-44810
<img width="682" alt="image" src="https://github.com/apache/spark/assets/15246973/9b78abb2-7907-4ff5-9177-0e09b5f5a9b5">
<img width="706" alt="image" src="https://github.com/apache/spark/assets/15246973/64f61727-80c2-4946-826c-0940b3ab288d">
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
- Add new UT & existed UT.
- Pass GA.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48363][SQL] Cleanup some redundant codes in `from_xml` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #46674:
URL: https://github.com/apache/spark/pull/46674#issuecomment-2121561163
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48363][SQL] Cleanup some redundant codes in `from_xml` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #46674: [SPARK-48363][SQL] Cleanup some redundant codes in `from_xml`
URL: https://github.com/apache/spark/pull/46674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48363][SQL] Cleanup some redundant codes in `from_xml` [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #46674:
URL: https://github.com/apache/spark/pull/46674#issuecomment-2121446653
cc @sandip-db @HyukjinKwon @cloud-fan @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org