[jira] [Commented] (CALCITE-4282) Promote the window table functions window attribute data type with precision 3

["Danny Chen (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205927#comment-17205927 ] 

Danny Chen commented on CALCITE-4282:
-------------------------------------

Yes, we may need some refactoring to the checkers, because the {{TIME_COL}} was contained in the descriptor.

> Promote the window table functions window attribute data type with precision 3
> ------------------------------------------------------------------------------
>
>                 Key: CALCITE-4282
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4282
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.25.0
>            Reporter: Danny Chen
>            Assignee: Danny Chen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.26.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Now the {{window_start}} and {{window_end}} has a type of a Timestamp with default system precision. But, actually, many DB vendors has default precision as 6 (which is also defined in the SQL standard).
> We better promote the precision to 3 because:
> 1. For windowing, time unit as millisecond is enough
> 2. Make the precision deterministic instead of overriding by each engine's default one



--
This message was sent by Atlassian Jira
(v8.3.4#803005)