[GitHub] [hbase] virajjasani commented on a change in pull request #1346: HBASE-23937 : Support Online LargeLogs similar to SlowLogs APIs

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #1346: HBASE-23937 : Support Online LargeLogs similar to SlowLogs APIs
URL: https://github.com/apache/hbase/pull/1346#discussion_r399757932
 
 

 ##########
 File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
 ##########
 @@ -2276,6 +2276,18 @@ boolean snapshotCleanupSwitch(final boolean on, final boolean synchronous)
   List<SlowLogRecord> getSlowLogResponses(final Set<ServerName> serverNames,
       final SlowLogQueryFilter slowLogQueryFilter) throws IOException;
 
+  /**
+   * Retrieves online large RPC logs from the provided list of
+   * RegionServers
+   *
+   * @param serverNames Server names to get slowlog responses from
+   * @param largeLogQueryFilter filter to be used if provided
+   * @return online slowlog response list
+   * @throws IOException if a remote or network exception occurs
+   */
+  List<SlowLogRecord> getLargeLogResponses(final Set<ServerName> serverNames,
+    final SlowLogQueryFilter largeLogQueryFilter) throws IOException;
 
 Review comment:
   @bharathv I am planning to change `SlowLogRecord` to `OnlineLogRecord` and `SlowLogQueryFilter` to `OnlineLogQueryFilter`. Will make that change before merging the PR because this class is being referred at multiple places (in thrift), so will be redundant refactor for now (to make review relevant to actual changes).
   
   Also, the overall change is providing new API in Admin and shell command and to have 2 flags at server side (isSlowLog and isLargeLog) to fetch relevant records from server.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services