You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/14 23:02:16 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request #1450: Planner code cleanup
alamb opened a new pull request #1450:
URL: https://github.com/apache/arrow-datafusion/pull/1450
This is a proposed minor code cleanup I noticed while working on https://github.com/apache/arrow-datafusion/pull/1449
Though to be honest it is still pretty messy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1450: Planner code cleanup
Posted by GitBox <gi...@apache.org>.
xudong963 commented on a change in pull request #1450:
URL: https://github.com/apache/arrow-datafusion/pull/1450#discussion_r769212919
##########
File path: datafusion/src/sql/planner.rs
##########
@@ -1341,22 +1341,25 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
}
SQLExpr::CompoundIdentifier(ids) => {
- let mut var_names = vec![];
- for id in ids {
- var_names.push(id.value.clone());
- }
+ let mut var_names: Vec<_> =
Review comment:
This is more rust flavor 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #1450: Planner code cleanup
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1450:
URL: https://github.com/apache/arrow-datafusion/pull/1450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org