[GitHub] [systemds] Baunsgaard commented on pull request #1087: Federated Read

[GitBox <gi...@apache.org>]

Baunsgaard commented on pull request #1087:
URL: https://github.com/apache/systemds/pull/1087#issuecomment-716190136


   > In general I really like the PR, but I would propose one change for the json layout.
   > Current:
   > 
   > ```json
   > {
   >     "[0, 0] - [5, 13]": {
   >         "filepath": "target/testTemp/functions/federated/io/FederatedReaderTest/in/X1",
   >         "dataType": "MATRIX",
   >         "address": "localhost:42441"
   >     },
   >     "[5, 0] - [10, 13]": {
   >         "filepath": "target/testTemp/functions/federated/io/FederatedReaderTest/in/X2",
   >         "dataType": "MATRIX",
   >         "address": "localhost:36989"
   >     }
   > }
   > ```
   > 
   > My proposal:
   > 
   > ```json
   > [
   >     {
   >         "filepath": "target/testTemp/functions/federated/io/FederatedReaderTest/in/X1",
   >         "dataType": "MATRIX",
   >         "address": "localhost:42441",
   >         "begin": [0, 0],
   >         "end": [5, 13]
   >     },
   >     {
   >         "filepath": "target/testTemp/functions/federated/io/FederatedReaderTest/in/X2",
   >         "dataType": "MATRIX",
   >         "address": "localhost:36989",
   >         "begin": [5, 0],
   >         "end": [10, 13]
   >     }
   > ]
   > ```
   
   Sure will change it to that :) it looks nicer


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org