[GitHub] [dubbo] chickenlj commented on a diff in pull request #10356: feat: add mesh enable config and process url in mesh mode

[GitBox <gi...@apache.org>]

chickenlj commented on code in PR #10356:
URL: https://github.com/apache/dubbo/pull/10356#discussion_r940820599


##########
dubbo-common/src/main/java/org/apache/dubbo/common/constants/CommonConstants.java:
##########
@@ -546,4 +546,26 @@ public interface CommonConstants {
 
     String PREFER_JSON_FRAMEWORK_NAME = "dubbo.json-framework.prefer";
 
+    /**
+     * @since 3.1.0
+     */
+    String MESH_ENABLE = "mesh-enable";
+
+    /**
+     * @since 3.1.0
+     */
+    Integer DEFAULT_MESH_PORT = 80;

Review Comment:
   Can we make the default mesh port the same as triple's default port? I think the default `80` port is not helpful for users using Triple, which is probably the most common case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org