You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@airavata.apache.org by hasinitg <gi...@git.apache.org> on 2015/07/19 17:56:38 UTC

[GitHub] airavata pull request: Pull request containing the work carried ou...

GitHub user hasinitg opened a pull request:

    https://github.com/apache/airavata/pull/23

    Pull request containing the work carried out in the week of 12th-18th July

    Hi Suresh,
    
    This pull request contains the following major changes:
    1) enforcing security through thrift method interception supported by Guice AOP framework (as opposed to the in-method security enforcement) - I will document the details about this.
    2) changing all API methods to accept AuthzToken (in both thrift definition file and AiravataServerHandler)
    Please note that when changing the API method implementation in AiravataServerHandler,
    - deprecated methods were not changed
    - new method with "Internal" suffix was introduced for couple of methods which were called by other methods with in the API itself, in order to avoid multiple security checks on the same API call
    3) Fixing the sample clients for compilation errors.
    
    Thanks,
    Hasini.
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hasinitg/airavata sprint4_pr2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/airavata/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit dc5244905d8585c4f750e78b04d8dce5670a968f
Author: hasinitg <ha...@gmail.com>
Date:   2015-07-14T18:24:32Z

    changing few API methods to adhere to security solution.

commit e0941f4ba3df1711f7acc29af16365d1e8f490ae
Author: hasinitg <ha...@gmail.com>
Date:   2015-07-15T05:10:16Z

    changed createProject method and added internal private method for isGatewayExist, to avoid chained API calls.

commit 4fae741d6e8c98e8f7978850c9cbd5f21418a355
Author: hasinitg <ha...@gmail.com>
Date:   2015-07-16T20:15:36Z

    adding security validation on API method calls through interception using the Guice AOP framework.

commit b515beeb1844b45867e573cfe9d064e42f918e30
Author: hasinitg <ha...@gmail.com>
Date:   2015-07-16T20:27:03Z

    Merge branch 'sprint3_pr2' into sprint4_pr1

commit 283e700d3088e0425c509895704ff76ac80c93fe
Author: hasinitg <ha...@gmail.com>
Date:   2015-07-17T14:12:19Z

    finished changing the API methods.

commit 7be309d7ffbbcb012573ecb8a44ebb7db077950f
Author: hasinitg <ha...@gmail.com>
Date:   2015-07-19T15:40:43Z

    fixed all compilation errors in the java client samples after the API changes.

commit 43fd3d7ff8d8f61bb6a84a68b5bf8e83ff836f2b
Author: hasinitg <ha...@gmail.com>
Date:   2015-07-19T15:44:36Z

    Merge branch 'sprint4_pr1' into sprint4_pr2

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] airavata pull request: Pull request containing the work carried ou...

Posted by hasinitg <gi...@git.apache.org>.

Github user hasinitg commented on the pull request:

    https://github.com/apache/airavata/pull/23#issuecomment-123211164
  
    Thank you Suresh.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] airavata pull request: Pull request containing the work carried ou...

Posted by hasinitg <gi...@git.apache.org>.

Github user hasinitg commented on the pull request:

    https://github.com/apache/airavata/pull/23#issuecomment-122924127
  
    Hi Suresh,
    
    This is a gentle follow up on this PR. Since this pull request has code changes in number of places, it could soon become unmergeable with the other commits made to the master.
    
    Thanks,
    Hasini.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] airavata pull request: Pull request containing the work carried ou...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/airavata/pull/23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] airavata pull request: Pull request containing the work carried ou...

Posted by smarru <gi...@git.apache.org>.

Github user smarru commented on the pull request:

    https://github.com/apache/airavata/pull/23#issuecomment-123155867
  
    Sorry for the delay hasini. This is now merged. I have some comments on guice, will continue the dev list conversation. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---