[GitHub] [cloudstack] rafaelweingartner edited a comment on pull request #4283: Removes unnecessary validations

[GitBox <gi...@apache.org>]

rafaelweingartner edited a comment on pull request #4283:
URL: https://github.com/apache/cloudstack/pull/4283#issuecomment-754104827


   **Please, check the code, and the cited PRs,** you can check there in the PR I created there is a method called `doesTargetStorageSupportNewDiskOffering` (https://github.com/apache/cloudstack/blob/261750c191f36ca93f0b8a030b00730b4a448c29/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java#L2272). I have not checked if somebody else also broke this check on master, but the code  I created (**please, refer to the PR, you can see the code there**) checks if the new disk offering matches the target storage. However, that is not mandatory, as I said, it can be used as a means to facilitate operational tasks, and it must be used wisely by operators. **Moreover, it has been merged, and it is in use by people.** I really do not see why so much resistance from you guys here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org