You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2009/11/27 17:50:52 UTC

Fix a build issue with finding apr-config for ctypesgen

I built ctypes-python for the first time today. It didn't pick up my
"apr" and "apr-util" locations automatically, and this patch fixes that.

[[[
Fix a problem in the automatic finding of 'apr-1-config' by
'make ctypes-python'.

* build/ac-macros/apr.m4
  (SVN_LIB_APR): Set the 'SVN_APR_CONFIG' substitution variable to the path
    of the 'apr-1-config' program.

* build/ac-macros/aprutil.m4
  (SVN_LIB_APRUTIL): Set the 'SVN_APRUTIL_CONFIG' substitution variable to
    the path of the 'apu-1-config' program.

* build/run_ctypesgen.sh
  Receive in arguments 9 and 10 the paths to the apr-config and apu-config
  executables, instead of their "prefix" directories, thus eliminating the
  incorrect assumption that they would be found in '<prefix>/bin'.
  The <exec-prefix> in which these are found is not necessarily <prefix>; in
  the Ubuntu 'libapr1' package that I am using, for example, <prefix> is
  empty and <exec-prefix> is '/usr'. (apr-1-config can tell us <prefix> but
  not <exec-prefix>; anyway, we already had to know its path and name to get
  that information out of it, so let's use what we knew.)
  This also eliminates the needless assumption that the config script is
  called 'apr-1-config' rather than, say, 'apr-config'.

* Makefile.in
  (ctypes-python): Pass SVN_APR_CONFIG and SVN_APRUTIL_CONFIG, instead of
    their generic 'prefix' directories, to run_ctypesgen.sh.
]]]

- Julian


Re: Fix a build issue with finding apr-config for ctypesgen

Posted by Julian Foad <ju...@btopenworld.com>.
On Fri, 2009-11-27, I (Julian Foad) wrote:
> I built ctypes-python for the first time today. It didn't pick up my
> "apr" and "apr-util" locations automatically, and this patch fixes that.

Committed revision 885372.

- Julian


> [[[
> Fix a problem in the automatic finding of 'apr-1-config' by
> 'make ctypes-python'.
> 
> * build/ac-macros/apr.m4
>   (SVN_LIB_APR): Set the 'SVN_APR_CONFIG' substitution variable to the path
>     of the 'apr-1-config' program.
> 
> * build/ac-macros/aprutil.m4
>   (SVN_LIB_APRUTIL): Set the 'SVN_APRUTIL_CONFIG' substitution variable to
>     the path of the 'apu-1-config' program.
> 
> * build/run_ctypesgen.sh
>   Receive in arguments 9 and 10 the paths to the apr-config and apu-config
>   executables, instead of their "prefix" directories, thus eliminating the
>   incorrect assumption that they would be found in '<prefix>/bin'.
>   The <exec-prefix> in which these are found is not necessarily <prefix>; in
>   the Ubuntu 'libapr1' package that I am using, for example, <prefix> is
>   empty and <exec-prefix> is '/usr'. (apr-1-config can tell us <prefix> but
>   not <exec-prefix>; anyway, we already had to know its path and name to get
>   that information out of it, so let's use what we knew.)
>   This also eliminates the needless assumption that the config script is
>   called 'apr-1-config' rather than, say, 'apr-config'.
> 
> * Makefile.in
>   (ctypes-python): Pass SVN_APR_CONFIG and SVN_APRUTIL_CONFIG, instead of
>     their generic 'prefix' directories, to run_ctypesgen.sh.
> ]]]