You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/09/22 20:03:07 UTC

[GitHub] [cassandra] clohfink commented on a change in pull request #750: CASSANDRA-15164 clear any overflow for deserialized cells-per-partition and partition… … size histograms

clohfink commented on a change in pull request #750:
URL: https://github.com/apache/cassandra/pull/750#discussion_r492999030



##########
File path: src/java/org/apache/cassandra/io/sstable/metadata/StatsMetadata.java
##########
@@ -340,7 +345,27 @@ public void serialize(Version version, StatsMetadata component, DataOutputPlus o
         public StatsMetadata deserialize(Version version, DataInputPlus in) throws IOException
         {
             EstimatedHistogram partitionSizes = EstimatedHistogram.serializer.deserialize(in);
+            
+            if (partitionSizes.isOverflowed())
+            {
+                logger.warn("Deserialized partition size histogram with {} values greater than the maximum of {}. " +

Review comment:
       would this be candidate for no spam logger? I think it will mainly be on open() but might be worth considering (ok to ignore this)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org