[GitHub] [netbeans] eirikbakke commented on pull request #5762: Apply a color filter on UI icons on FlatLAF Dark

["eirikbakke (via GitHub)" <gi...@apache.org>]

eirikbakke commented on PR #5762:
URL: https://github.com/apache/netbeans/pull/5762#issuecomment-1493139746

   Yes, I used DarkIconFilter first and then came up with the OklabDarkIconFilter as an improvement.
   
   > There are better ways to approach this issue, if we actually need to.
   
   What would that be? Redrawing all the icons?
   
   The style for the new SVG icons (written up at https://issues.apache.org/jira/browse/NETBEANS-2617 ) avoids the problem of inverted depth, by getting rid of the shadow/highlight detail that were present in the old bitmap icons. But we only have these new icons in a few areas for now, such as the editor toolbar. So maybe this is something to return to once somebody volunteers to make more SVG icons...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists