You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cayenne.apache.org by Andrus Adamchik <an...@objectstyle.org> on 2009/12/02 17:38:36 UTC
Re: [jira] Commented: (CAY-1323) oracle.sql.TIMESTAMP in Result of query
Hi Evgeny,
Let me take this to dev... Thanks for providing all the information on
the issue and working on the fix. This is rather valuable to Cayenne,
as your system has a number of use cases that seem to be pretty unique
in this community, and you can find things that nobody else will.
(Also hope that your Apache account will be created soon, so that you
can take over this Jira and commit it yourself)
> As you wrote: "Cayenne Mapping can only contain JDBC types"
Let me clarify. This was referring to the DB part of the mapping. On
the Java part we can map any custom types. And we do in fact. Cayenne
is definitely not limited to the types listed in the JDBC spec, again
on the object end of the mapping.
> How to fix... mm have thoughts that OracleAdapter can help us...
> need some time to look there inside
Yes please.
Let me comment on the fix versions to avoid misunderstanding. The fix
versions will depend on the nature of the fix and the definition of
the problem. Just returning an Oracle type from an unmapped query is
IMO not a bug (actually it looks more like a bug in Oracle driver from
your examples, and what I found via Google). On the other hand
returning correct value from SQLTemplate with an explicit #result(),
is something that we need to handle correctly ourselves.
So the second case should probably be fixed on all stable branches.
The first case would require us to redefine how Cayenne works. For
instance we may decide that from 3.1 all Oracle internal types should
be converted to JDBC default types (unless otherwise specified by the
user). But we won't be able to include that change in the "stable"
releases.
Andrus
On Dec 2, 2009, at 6:16 PM, Evgeny Ryabitskiy (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/CAY-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784887
> #action_12784887 ]
>
> Evgeny Ryabitskiy commented on CAY-1323:
> ----------------------------------------
>
> I think I finished my Investigation. If you wish I can add some
> JUnit for this UC.
>
> You can add "Fix Version" as you wish. But I think it should be
> fixed in all branches (1.0, 2.0, 3.0).
> It is no expectable behavior.... As you wrote: "Cayenne Mapping can
> only contain JDBC types"
>
> How to fix... mm have thoughts that OracleAdapter can help us...
> need some time to look there inside
>
>> oracle.sql.TIMESTAMP in Result of query
>> ---------------------------------------
>>
>> Key: CAY-1323
>> URL: https://issues.apache.org/jira/browse/CAY-1323
>> Project: Cayenne
>> Issue Type: Bug
>> Components: Cayenne Core Library
>> Affects Versions: 2.0.5, 3.0 beta 1
>> Reporter: Evgeny Ryabitskiy
>> Assignee: Andrus Adamchik
>> Attachments: cayenne.xml, OracleTimestampTest.java,
>> OracleTimestampTestMap.map.xml
>>
>>
>> Result of query from column of timestamp type was mapped to
>> oracle.sql.TIMESTAMP.
>> I think it should be mapped to standard JDBS TIMESTAMP
>> I am using latest official Oracle JDBC driver.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
Re: [jira] Commented: (CAY-1323) oracle.sql.TIMESTAMP in Result of
query
Posted by Evgeny Ryabitskiy <ev...@gmail.com>.
Ok. Now it is much clear. Thx for explaining.
Evgeny.
2009/12/2 Andrus Adamchik <an...@objectstyle.org>:
> Hi Evgeny,
>
> Let me take this to dev... Thanks for providing all the information on the
> issue and working on the fix. This is rather valuable to Cayenne, as your
> system has a number of use cases that seem to be pretty unique in this
> community, and you can find things that nobody else will. (Also hope that
> your Apache account will be created soon, so that you can take over this
> Jira and commit it yourself)
>
>> As you wrote: "Cayenne Mapping can only contain JDBC types"
>
> Let me clarify. This was referring to the DB part of the mapping. On the
> Java part we can map any custom types. And we do in fact. Cayenne is
> definitely not limited to the types listed in the JDBC spec, again on the
> object end of the mapping.
>
>> How to fix... mm have thoughts that OracleAdapter can help us... need some
>> time to look there inside
>
> Yes please.
>
> Let me comment on the fix versions to avoid misunderstanding. The fix
> versions will depend on the nature of the fix and the definition of the
> problem. Just returning an Oracle type from an unmapped query is IMO not a
> bug (actually it looks more like a bug in Oracle driver from your examples,
> and what I found via Google). On the other hand returning correct value from
> SQLTemplate with an explicit #result(), is something that we need to handle
> correctly ourselves.
>
> So the second case should probably be fixed on all stable branches.
>
> The first case would require us to redefine how Cayenne works. For instance
> we may decide that from 3.1 all Oracle internal types should be converted to
> JDBC default types (unless otherwise specified by the user). But we won't be
> able to include that change in the "stable" releases.
>
> Andrus
>
>
> On Dec 2, 2009, at 6:16 PM, Evgeny Ryabitskiy (JIRA) wrote:
>>
>> [
>> https://issues.apache.org/jira/browse/CAY-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784887#action_12784887
>> ]
>>
>> Evgeny Ryabitskiy commented on CAY-1323:
>> ----------------------------------------
>>
>> I think I finished my Investigation. If you wish I can add some JUnit for
>> this UC.
>>
>> You can add "Fix Version" as you wish. But I think it should be fixed in
>> all branches (1.0, 2.0, 3.0).
>> It is no expectable behavior.... As you wrote: "Cayenne Mapping can only
>> contain JDBC types"
>>
>> How to fix... mm have thoughts that OracleAdapter can help us... need some
>> time to look there inside
>>
>>> oracle.sql.TIMESTAMP in Result of query
>>> ---------------------------------------
>>>
>>> Key: CAY-1323
>>> URL: https://issues.apache.org/jira/browse/CAY-1323
>>> Project: Cayenne
>>> Issue Type: Bug
>>> Components: Cayenne Core Library
>>> Affects Versions: 2.0.5, 3.0 beta 1
>>> Reporter: Evgeny Ryabitskiy
>>> Assignee: Andrus Adamchik
>>> Attachments: cayenne.xml, OracleTimestampTest.java,
>>> OracleTimestampTestMap.map.xml
>>>
>>>
>>> Result of query from column of timestamp type was mapped to
>>> oracle.sql.TIMESTAMP.
>>> I think it should be mapped to standard JDBS TIMESTAMP
>>> I am using latest official Oracle JDBC driver.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
>
RE: Cayenne Oracle tests
Posted by Рябицкий Евгений <er...@diasoft.ru>.
Yeah... so much to do...
BTW I patially fixed that bug with oracle TIMESTAMP mapping. Think it will be fixed this weak. Was idea to add JUnit, so I will try AccessStackAdapter.
Evgeny.
-----Original Message-----
From: Andrus Adamchik [mailto:andrus@objectstyle.org]
Sent: Thursday, December 03, 2009 3:39 PM
To: dev@cayenne.apache.org
Subject: Re: Cayenne Oracle tests
We don't have per-DB tests. There's some weak support for excluding
certain tests on some DB's (see
org.apache.cayenne.unit.AccessStackAdapter).
Olga recently did the research of an implementation of per-DB test
capabilities. This hasn't been discussed yet in detail, but this is
something that I'd like to have in 3.1... Specifically this would
require migration of the tests to TestNG, and organizing the tests
into "test groups". Each target database can be associated with one or
more test groups. So DB-specific stuff can be placed in a DB-specific
group.
For now AccessStackAdapter and subclasses are the only way to achieve
that.
Andrus
On Dec 3, 2009, at 1:53 PM, Рябицкий Евгений wrote:
> Yeah. Thx...
> But what if I want to add some Oracle-specific test?
> Do we have some?
>
> Evgeny.
>
>
>
>
>
>
> -----Original Message-----
> From: Aristedes Maniatis [mailto:ari@maniatis.org]
> Sent: Thursday, December 03, 2009 1:44 PM
> To: dev@cayenne.apache.org
> Subject: Re: Cayenne Oracle tests
>
> On 3/12/09 8:50 PM, Рябицкий Евгений wrote:
>> Hello!
>>
>> Can some one explain me how Cayenne is tested over Oracle.
>> Just going to add some Oracle-specific JUnit test. How to do it?
>> Any example... notes... documentation?
>>
>> Evgeny.
>
> If you want to run the unit tests... http://cayenne.apache.org/running-unit-tests.html
>
>
> Ari
>
>
> -------------------------->
> Aristedes Maniatis
> GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A
>
Re: Cayenne Oracle tests
Posted by Andrus Adamchik <an...@objectstyle.org>.
We don't have per-DB tests. There's some weak support for excluding
certain tests on some DB's (see
org.apache.cayenne.unit.AccessStackAdapter).
Olga recently did the research of an implementation of per-DB test
capabilities. This hasn't been discussed yet in detail, but this is
something that I'd like to have in 3.1... Specifically this would
require migration of the tests to TestNG, and organizing the tests
into "test groups". Each target database can be associated with one or
more test groups. So DB-specific stuff can be placed in a DB-specific
group.
For now AccessStackAdapter and subclasses are the only way to achieve
that.
Andrus
On Dec 3, 2009, at 1:53 PM, Рябицкий Евгений wrote:
> Yeah. Thx...
> But what if I want to add some Oracle-specific test?
> Do we have some?
>
> Evgeny.
>
>
>
>
>
>
> -----Original Message-----
> From: Aristedes Maniatis [mailto:ari@maniatis.org]
> Sent: Thursday, December 03, 2009 1:44 PM
> To: dev@cayenne.apache.org
> Subject: Re: Cayenne Oracle tests
>
> On 3/12/09 8:50 PM, Рябицкий Евгений wrote:
>> Hello!
>>
>> Can some one explain me how Cayenne is tested over Oracle.
>> Just going to add some Oracle-specific JUnit test. How to do it?
>> Any example... notes... documentation?
>>
>> Evgeny.
>
> If you want to run the unit tests... http://cayenne.apache.org/running-unit-tests.html
>
>
> Ari
>
>
> -------------------------->
> Aristedes Maniatis
> GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A
>
RE: Cayenne Oracle tests
Posted by Рябицкий Евгений <er...@diasoft.ru>.
Yeah. Thx...
But what if I want to add some Oracle-specific test?
Do we have some?
Evgeny.
-----Original Message-----
From: Aristedes Maniatis [mailto:ari@maniatis.org]
Sent: Thursday, December 03, 2009 1:44 PM
To: dev@cayenne.apache.org
Subject: Re: Cayenne Oracle tests
On 3/12/09 8:50 PM, Рябицкий Евгений wrote:
> Hello!
>
> Can some one explain me how Cayenne is tested over Oracle.
> Just going to add some Oracle-specific JUnit test. How to do it?
> Any example... notes... documentation?
>
> Evgeny.
If you want to run the unit tests... http://cayenne.apache.org/running-unit-tests.html
Ari
-------------------------->
Aristedes Maniatis
GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A
Re: Cayenne Oracle tests
Posted by Aristedes Maniatis <ar...@maniatis.org>.
On 3/12/09 8:50 PM, Рябицкий Евгений wrote:
> Hello!
>
> Can some one explain me how Cayenne is tested over Oracle.
> Just going to add some Oracle-specific JUnit test. How to do it?
> Any example... notes... documentation?
>
> Evgeny.
If you want to run the unit tests... http://cayenne.apache.org/running-unit-tests.html
Ari
-------------------------->
Aristedes Maniatis
GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A
Cayenne Oracle tests
Posted by Рябицкий Евгений <er...@diasoft.ru>.
Hello!
Can some one explain me how Cayenne is tested over Oracle.
Just going to add some Oracle-specific JUnit test. How to do it?
Any example... notes... documentation?
Evgeny.
On Dec 2, 2009, at 6:16 PM, Evgeny Ryabitskiy (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/CAY-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784887
> #action_12784887 ]
>
> Evgeny Ryabitskiy commented on CAY-1323:
> ----------------------------------------
>
> I think I finished my Investigation. If you wish I can add some
> JUnit for this UC.
>
> You can add "Fix Version" as you wish. But I think it should be
> fixed in all branches (1.0, 2.0, 3.0).
> It is no expectable behavior.... As you wrote: "Cayenne Mapping can
> only contain JDBC types"
>
> How to fix... mm have thoughts that OracleAdapter can help us...
> need some time to look there inside
>
>> oracle.sql.TIMESTAMP in Result of query
>> ---------------------------------------
>>
>> Key: CAY-1323
>> URL: https://issues.apache.org/jira/browse/CAY-1323
>> Project: Cayenne
>> Issue Type: Bug
>> Components: Cayenne Core Library
>> Affects Versions: 2.0.5, 3.0 beta 1
>> Reporter: Evgeny Ryabitskiy
>> Assignee: Andrus Adamchik
>> Attachments: cayenne.xml, OracleTimestampTest.java,
>> OracleTimestampTestMap.map.xml
>>
>>
>> Result of query from column of timestamp type was mapped to
>> oracle.sql.TIMESTAMP.
>> I think it should be mapped to standard JDBS TIMESTAMP
>> I am using latest official Oracle JDBC driver.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>