You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by Martin Benda <be...@bendis.cz> on 2007/01/03 10:48:57 UTC

WICKET-156 fixed?

Hi,

I have just updated wicket/trunk from SVN (rev. 492084), run 
wicket-examples -> ajax -> Form Example and the example is still not working 
(as described in WICKET-156).

Is it just me or the bug is not fixed?

I see that Page#detach() is now caled from AjaxRequestTarget, but since the 
page is not attached during the ajax request, the method Page#onDetach() 
(which calls detachModels()) is not executed... IMHO a simple fix could be to 
remove Page#detachModels() and call detachModels() from 
Component#onDetach() - it works for me but I'm not sure if it breaks anything 
else...

Regards,
Bendis

Re: WICKET-156 fixed?

Posted by Martin Benda <ma...@cleverlance.com>.

Great, it works fine now :-) After the refactorization the attach/detach logic 
looks simplified and more robust.

Bendis

Dne středa 03 leden 2007 18:00 Igor Vaynberg napsal(a):
> well it was fixed, and then i broke it again with the attach/detach
> refactor i did :) now its fixed again.
>
> we are still thinking about how best to deal with attach/detach
>
> -igor
>
> On 1/3/07, Martin Benda <be...@bendis.cz> wrote:
> > Hi,
> >
> > I have just updated wicket/trunk from SVN (rev. 492084), run
> > wicket-examples -> ajax -> Form Example and the example is still not
> > working
> > (as described in WICKET-156).
> >
> > Is it just me or the bug is not fixed?
> >
> > I see that Page#detach() is now caled from AjaxRequestTarget, but since
> > the
> > page is not attached during the ajax request, the method Page#onDetach()
> > (which calls detachModels()) is not executed... IMHO a simple fix could
> > be to
> > remove Page#detachModels() and call detachModels() from
> > Component#onDetach() - it works for me but I'm not sure if it breaks
> > anything
> > else...
> >
> > Regards,
> > Bendis

Re: WICKET-156 fixed?

Posted by Igor Vaynberg <ig...@gmail.com>.

well it was fixed, and then i broke it again with the attach/detach refactor
i did :) now its fixed again.

we are still thinking about how best to deal with attach/detach

-igor


On 1/3/07, Martin Benda <be...@bendis.cz> wrote:
>
> Hi,
>
> I have just updated wicket/trunk from SVN (rev. 492084), run
> wicket-examples -> ajax -> Form Example and the example is still not
> working
> (as described in WICKET-156).
>
> Is it just me or the bug is not fixed?
>
> I see that Page#detach() is now caled from AjaxRequestTarget, but since
> the
> page is not attached during the ajax request, the method Page#onDetach()
> (which calls detachModels()) is not executed... IMHO a simple fix could be
> to
> remove Page#detachModels() and call detachModels() from
> Component#onDetach() - it works for me but I'm not sure if it breaks
> anything
> else...
>
> Regards,
> Bendis
>