You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/07/11 22:51:56 UTC
Review Request 67889: Installed google's signal handler for libprocess
benchmarks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67889/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Repository: mesos
Description
-------
This will provide a stack trace if the benchmarks crash, the
approach here was followed from the libprocess test main.cpp.
Diffs
-----
3rdparty/libprocess/src/tests/benchmarks.cpp 604122a2f33d7abfab92631d9eac33b6753e846b
Diff: https://reviews.apache.org/r/67889/diff/1/
Testing
-------
Ran with a crash, and obtained the stack trace.
Thanks,
Benjamin Mahler
Re: Review Request 67889: Installed google's signal handler for
libprocess benchmarks.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67889/#review206462
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On July 11, 2018, 10:51 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67889/
> -----------------------------------------------------------
>
> (Updated July 11, 2018, 10:51 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This will provide a stack trace if the benchmarks crash, the
> approach here was followed from the libprocess test main.cpp.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/benchmarks.cpp 604122a2f33d7abfab92631d9eac33b6753e846b
>
>
> Diff: https://reviews.apache.org/r/67889/diff/1/
>
>
> Testing
> -------
>
> Ran with a crash, and obtained the stack trace.
>
>
> Thanks,
>
> Benjamin Mahler
>
>