You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/30 22:43:25 UTC
[GitHub] [druid] ccaominh commented on a change in pull request #10445: Fix the task id creation in CompactionTask
ccaominh commented on a change in pull request #10445:
URL: https://github.com/apache/druid/pull/10445#discussion_r497840982
##########
File path: indexing-service/src/test/java/org/apache/druid/indexing/common/task/CompactionTaskParallelRunTest.java
##########
@@ -219,6 +219,37 @@ public void testRunParallelWithRangePartitioning()
}
}
+ @Test
+ public void testRunParallelWithRangePartitioningWithSingleTask()
+ {
+ // Range partitioning is not supported with segment lock yet
+ if (lockGranularity == LockGranularity.SEGMENT) {
+ return;
+ }
+ runIndexTask(null, true);
+
+ final Builder builder = new Builder(
+ DATA_SOURCE,
+ getSegmentLoaderFactory(),
+ RETRY_POLICY_FACTORY
+ );
+ final CompactionTask compactionTask = builder
+ .inputSpec(new CompactionIntervalSpec(INTERVAL_TO_INDEX, null))
+ .tuningConfig(newTuningConfig(new SingleDimensionPartitionsSpec(7, null, "dim", false), 1, true))
+ .build();
+
+ final Set<DataSegment> compactedSegments = runTask(compactionTask);
+ final CompactionState expectedState = new CompactionState(
+ new SingleDimensionPartitionsSpec(7, null, "dim", false),
+ compactionTask.getTuningConfig().getIndexSpec().asMap(getObjectMapper())
+ );
+ for (DataSegment segment : compactedSegments) {
+ // Expecte compaction state to exist as store compaction state by default
Review comment:
There's at least one typo in this comment
##########
File path: indexing-service/src/test/java/org/apache/druid/indexing/common/task/CompactionTaskParallelRunTest.java
##########
@@ -219,6 +219,37 @@ public void testRunParallelWithRangePartitioning()
}
}
+ @Test
+ public void testRunParallelWithRangePartitioningWithSingleTask()
+ {
+ // Range partitioning is not supported with segment lock yet
+ if (lockGranularity == LockGranularity.SEGMENT) {
+ return;
+ }
Review comment:
[JUnit has an `Assume` API](https://junit.org/junit4/javadoc/4.12/org/junit/Assume.html), which could be a good fit here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org