You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/10 17:05:50 UTC
[GitHub] [ozone] bshashikant opened a new pull request #2025: HDDS-4957. Fix flaky test TestSCMInstallSnapshotWithHA#testInstallCorruptedCheckpointFailure
bshashikant opened a new pull request #2025:
URL: https://github.com/apache/ozone/pull/2025
## What changes were proposed in this pull request?
The test assumes that a follower node must be behind the leader during the final validation assertions. Fix is to not start the follower server itself , so that it always lags behind the leader at any point of time.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4957
## How was this patch tested?
Fixed UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on pull request #2025: HDDS-4957. Fix flaky test TestSCMInstallSnapshotWithHA#testInstallCorruptedCheckpointFailure
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #2025:
URL: https://github.com/apache/ozone/pull/2025#issuecomment-795926015
Retriggering the CI check again after a clean CI run , to ensure its not flaky.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia closed pull request #2025: HDDS-4957. Fix flaky test TestSCMInstallSnapshotWithHA#testInstallCorruptedCheckpointFailure
Posted by GitBox <gi...@apache.org>.
amaliujia closed pull request #2025:
URL: https://github.com/apache/ozone/pull/2025
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #2025: HDDS-4957. Fix flaky test TestSCMInstallSnapshotWithHA#testInstallCorruptedCheckpointFailure
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #2025:
URL: https://github.com/apache/ozone/pull/2025#issuecomment-796166284
retrigger CI test third time so ensure it is not flaky. After this time I can merge this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia edited a comment on pull request #2025: HDDS-4957. Fix flaky test TestSCMInstallSnapshotWithHA#testInstallCorruptedCheckpointFailure
Posted by GitBox <gi...@apache.org>.
amaliujia edited a comment on pull request #2025:
URL: https://github.com/apache/ozone/pull/2025#issuecomment-796166284
I saw in the second time all CI checks had passed.
Retrigger CI test third time so ensure it is not flaky. After this time I can merge this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GlenGeng commented on pull request #2025: HDDS-4957. Fix flaky test TestSCMInstallSnapshotWithHA#testInstallCorruptedCheckpointFailure
Posted by GitBox <gi...@apache.org>.
GlenGeng commented on pull request #2025:
URL: https://github.com/apache/ozone/pull/2025#issuecomment-796381737
Thanks @bshashikant for the fix, and @amaliujia for the review and verification in CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #2025: HDDS-4957. Fix flaky test TestSCMInstallSnapshotWithHA#testInstallCorruptedCheckpointFailure
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #2025:
URL: https://github.com/apache/ozone/pull/2025#issuecomment-796290659
@bshashikant thanks for this fix!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2025: HDDS-4957. Fix flaky test TestSCMInstallSnapshotWithHA#testInstallCorruptedCheckpointFailure
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2025:
URL: https://github.com/apache/ozone/pull/2025#issuecomment-796569400
FYI, it is possible to repeat a single test several times, see @elek's guide at https://cwiki.apache.org/confluence/display/HADOOP/Github+Actions+tips+and+tricks
Additionally, with JUnit 5 it's as simple as changing `@Test` to `@RepeatedTest(10)` (adjust repetitions as needed) for the flaky test case. Fork timeout also needs to be increased.
Ran the test 2x10 times without issues:
https://github.com/adoroszlai/hadoop-ozone/runs/2080365955#step:4:3826
https://github.com/adoroszlai/hadoop-ozone/runs/2080365955#step:4:3931
Here's my change for reference:
https://github.com/adoroszlai/hadoop-ozone/commit/73bea4db8bf4826f7f31eb24d1951e853197ae22
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia merged pull request #2025: HDDS-4957. Fix flaky test TestSCMInstallSnapshotWithHA#testInstallCorruptedCheckpointFailure
Posted by GitBox <gi...@apache.org>.
amaliujia merged pull request #2025:
URL: https://github.com/apache/ozone/pull/2025
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on pull request #2025: HDDS-4957. Fix flaky test TestSCMInstallSnapshotWithHA#testInstallCorruptedCheckpointFailure
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #2025:
URL: https://github.com/apache/ozone/pull/2025#issuecomment-795749310
@GlenGeng , can you please take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org