[hop] branch release1.2.0 updated: [DOC] fix flink sample docs

[ha...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hansva pushed a commit to branch release1.2.0
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/release1.2.0 by this push:
     new 5212a6fae0 [DOC] fix flink sample docs
5212a6fae0 is described below

commit 5212a6fae0b2724ec4419f2242797b40a73c3a38
Author: Hans Van Akelyen <ha...@gmail.com>
AuthorDate: Wed Apr 13 11:16:29 2022 +0200

    [DOC] fix flink sample docs
---
 .../ROOT/assets/images/beam/beam-flink-download.png | Bin 61211 -> 38033 bytes
 .../images/beam/beam-flink-run-config-variables.png | Bin 0 -> 91465 bytes
 .../pages/pipeline/beam/beam-samples-flink.adoc     |   7 +++++--
 .../pipeline/beam/getting-started-with-beam.adoc    |   4 ++++
 4 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/docs/hop-user-manual/modules/ROOT/assets/images/beam/beam-flink-download.png b/docs/hop-user-manual/modules/ROOT/assets/images/beam/beam-flink-download.png
index d19b2f7278..ac4f6f187c 100644
Binary files a/docs/hop-user-manual/modules/ROOT/assets/images/beam/beam-flink-download.png and b/docs/hop-user-manual/modules/ROOT/assets/images/beam/beam-flink-download.png differ
diff --git a/docs/hop-user-manual/modules/ROOT/assets/images/beam/beam-flink-run-config-variables.png b/docs/hop-user-manual/modules/ROOT/assets/images/beam/beam-flink-run-config-variables.png
new file mode 100644
index 0000000000..420dc7a76c
Binary files /dev/null and b/docs/hop-user-manual/modules/ROOT/assets/images/beam/beam-flink-run-config-variables.png differ
diff --git a/docs/hop-user-manual/modules/ROOT/pages/pipeline/beam/beam-samples-flink.adoc b/docs/hop-user-manual/modules/ROOT/pages/pipeline/beam/beam-samples-flink.adoc
index 1c4ad38510..c832528920 100644
--- a/docs/hop-user-manual/modules/ROOT/pages/pipeline/beam/beam-samples-flink.adoc
+++ b/docs/hop-user-manual/modules/ROOT/pages/pipeline/beam/beam-samples-flink.adoc
@@ -26,7 +26,7 @@ under the License.
 
 Check the xref:pipeline/beam/getting-started-with-beam.adoc#supportedversions[Supported Versions] on the Getting Started With Beam page to find the latest supported Flink version for your Hop version.
 
-For example, for Hop 1.2, the latest currently supported version is 1.13. Make sure to download Flink for a recent and JDK 8 compatible Scale version. For Flink 1.3.5, this is Scala 2.12.
+For example, for Hop 1.2, the latest currently supported version is 1.13. Make sure to download Flink for a recent and JDK 8 compatible Scale version. For Flink 1.3.6, this is Scala 2.11.
 
 Download your selected Flink version and unzip to a convenient location.
 
@@ -79,6 +79,10 @@ Set your Flink master to `[auto]` and export your Hop metadata again (see xref:p
 
 image:beam/beam-flink-run-config-host.png[Apache Beam - Flink run configuration - master, width="40%"]
 
+Unlike Spark you can not pass java options at runtime to the TaskManager. So we also want to set the `PROJECT_HOME` variable in the run configuration. This variable is used during execution to know where the source files are. (Metadata perspective -> Pipeline Run Configuration -> Flink -> Variables)
+
+image:beam/beam-flink-run-config-variables.png[Apache Beam - Flink run configuration - master, width="40%"]
+
 Use a command like the one below to pass all the information required by `flink run`.
 
 [source, shell]
@@ -86,7 +90,6 @@ Use a command like the one below to pass all the information required by `flink
 bin/flink run \
   --class org.apache.hop.beam.run.MainBeam \
   --parallelism 2 \
-  -D PROJECT_HOME=<PATH>/hop/config/projects/samples/ \
   /opt/flink/hop-fat-jar.jar \
   <PATH>/hop/config/projects/samples/beam/pipelines/generate-synthetic-data.hpl \
   /opt/flink/hop-metadata.json \
diff --git a/docs/hop-user-manual/modules/ROOT/pages/pipeline/beam/getting-started-with-beam.adoc b/docs/hop-user-manual/modules/ROOT/pages/pipeline/beam/getting-started-with-beam.adoc
index 9ba9aa214f..c4f5dab5c2 100644
--- a/docs/hop-user-manual/modules/ROOT/pages/pipeline/beam/getting-started-with-beam.adoc
+++ b/docs/hop-user-manual/modules/ROOT/pages/pipeline/beam/getting-started-with-beam.adoc
@@ -61,6 +61,10 @@ Here is the documentation for the relevant plugins:
 |3.1.2
 |1.13
 
+|1.2.0
+|2.35.0
+|3.1.2 (scala 2.12)
+|1.13 (scala 2.11)
 |===
 
 == How are my pipelines executed?