You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by xumingming <gi...@git.apache.org> on 2017/07/06 03:33:59 UTC

[GitHub] beam pull request #3506: [BEAM-2550] add UnitTest for JOIN in DSL

GitHub user xumingming opened a pull request:

    https://github.com/apache/beam/pull/3506

    [BEAM-2550] add UnitTest for JOIN in DSL

    @XuMingmin @takidau 
    
    I have only tested `bounded vs bounded` join scenario, since we already have enumerated every cases like `bounded vs bounded`, `unbounded vs unbounded` in tests for `BeamJoinRel`, test here is mainly to test the integration of JOIN with the DSL methods.
    
    Also I kinda fixed a related bug in `BeamIOSourceRel` -- which have not setCoder for the rows. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xumingming/beam BEAM-2550-test-join-in-dsl

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3506.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3506
    
----
commit 5885d1cad12d28c453603e12c8a11f369d1d6d65
Author: James Xu <xu...@gmail.com>
Date:   2017-07-06T03:29:41Z

    [BEAM-2550] add UnitTest for JOIN in DSL

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #3506: [BEAM-2550] add UnitTest for JOIN in DSL

Posted by xumingming <gi...@git.apache.org>.
Github user xumingming closed the pull request at:

    https://github.com/apache/beam/pull/3506


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---